From 021cffaf112f802af193fe94560781ebac27a05d Mon Sep 17 00:00:00 2001 From: Uku Taht Date: Tue, 24 Aug 2021 15:23:01 +0300 Subject: [PATCH] Fix custom prop url detection --- .../stats/conversions/prop-breakdown.js | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/assets/js/dashboard/stats/conversions/prop-breakdown.js b/assets/js/dashboard/stats/conversions/prop-breakdown.js index f7c35b1b6..d90e0e772 100644 --- a/assets/js/dashboard/stats/conversions/prop-breakdown.js +++ b/assets/js/dashboard/stats/conversions/prop-breakdown.js @@ -9,6 +9,19 @@ import * as api from '../../api' const MOBILE_UPPER_WIDTH = 767 const DEFAULT_WIDTH = 1080 +// https://stackoverflow.com/a/43467144 +function isValidHttpUrl(string) { + let url; + + try { + url = new URL(string); + } catch (_) { + return false; + } + + return url.protocol === "http:" || url.protocol === "https:"; +} + export default class PropertyBreakdown extends React.Component { constructor(props) { super(props) @@ -59,7 +72,7 @@ export default class PropertyBreakdown extends React.Component { } renderUrl(value) { - if (value.is_url) { + if (isValidHttpUrl(value.name)) { return ( @@ -73,7 +86,7 @@ export default class PropertyBreakdown extends React.Component { return ( { value.name }