From 05d14774be83998d57446c06c949e68cc2025ac8 Mon Sep 17 00:00:00 2001 From: Adam Date: Tue, 14 Mar 2023 11:45:41 +0100 Subject: [PATCH] Fail CI when tests are logging (#2748) A re-iteration of a miserable attempt from #2694 Hi @dgvncsz0f, how you've been ;D --- .github/bin/log-watch.sh | 20 ++++++++++++++++++++ .github/workflows/elixir.yml | 2 +- 2 files changed, 21 insertions(+), 1 deletion(-) create mode 100755 .github/bin/log-watch.sh diff --git a/.github/bin/log-watch.sh b/.github/bin/log-watch.sh new file mode 100755 index 000000000..046481353 --- /dev/null +++ b/.github/bin/log-watch.sh @@ -0,0 +1,20 @@ +#!/bin/sh +fail=false +while read l +do + echo "$l" + if echo "$l" | grep -qP '\[(warning|error)\]' + then + fail=true; + fi +done + +if [ $fail = true ] +then + echo + echo "💀 The tests are logging, please capture logs. See:" + echo " - https://hexdocs.pm/ex_unit/1.12/ExUnit.CaptureLog.html" + echo " - https://hexdocs.pm/ex_unit/1.12/ExUnit.Case.html#module-known-tags" + echo + exit 1 +fi diff --git a/.github/workflows/elixir.yml b/.github/workflows/elixir.yml index 540b8a47c..444fecd84 100644 --- a/.github/workflows/elixir.yml +++ b/.github/workflows/elixir.yml @@ -71,7 +71,7 @@ jobs: - name: Check Credo Warnings run: mix credo diff --from-git-merge-base origin/master - name: Run tests - run: mix test --include slow --max-failures 1 --warnings-as-errors + run: mix test --include slow --max-failures 1 --warnings-as-errors | .github/bin/log-watch.sh - name: Check Dialyzer run: mix dialyzer env: