Add nil check to hashing

pull/994/head
Uku Taht 6 years ago
parent d30f6def0f
commit 0799138622

@ -196,7 +196,9 @@ defmodule PlausibleWeb.Api.ExternalController do
user_agent = List.first(Plug.Conn.get_req_header(conn, "user-agent")) || ""
ip_address = PlausibleWeb.RemoteIp.get(conn)
SipHash.hash!(salt, user_agent <> ip_address <> domain <> hostname)
if domain && hostname do
SipHash.hash!(salt, user_agent <> ip_address <> domain <> hostname)
end
end
defp calculate_screen_size(nil), do: nil

@ -587,7 +587,10 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
end
test "responds 400 when required fields are missing", %{conn: conn} do
params = %{}
params = %{
domain: "some-domain.com",
name: "pageview"
}
conn =
conn

Loading…
Cancel
Save