Ignore maps in prop values

pull/1479/head
Uku Taht 5 years ago
parent d25c46edec
commit 0edf4765d4

@ -168,7 +168,7 @@ defmodule PlausibleWeb.Api.ExternalController do
defp validate_custom_props(props) do
is_valid =
Enum.all?(props, fn {_key, val} ->
!is_list(val)
!is_list(val) && !is_map(val)
end)
if is_valid, do: :ok, else: :invalid_props

@ -495,6 +495,24 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
assert Map.get(event, :"meta.value") == []
end
test "ignores custom prop with map value", %{conn: conn} do
params = %{
name: "Signup",
url: "http://gigride.live/",
domain: "custom-prop-test-5.com",
props: Jason.encode!(%{foo: %{bar: "baz"}})
}
conn = post(conn, "/api/event", params)
assert conn.status == 202
event = get_event("custom-prop-test-5.com")
assert Map.get(event, :"meta.key") == []
assert Map.get(event, :"meta.value") == []
end
test "ignores a malformed referrer URL", %{conn: conn} do
params = %{
name: "pageview",

Loading…
Cancel
Save