diff --git a/.credo.exs b/.credo.exs index 27fe032e6..882e3a7c2 100644 --- a/.credo.exs +++ b/.credo.exs @@ -116,7 +116,7 @@ # {Credo.Check.Refactor.Apply, []}, {Credo.Check.Refactor.CondStatements, []}, - {Credo.Check.Refactor.CyclomaticComplexity, []}, + {Credo.Check.Refactor.CyclomaticComplexity, false}, {Credo.Check.Refactor.FunctionArity, []}, {Credo.Check.Refactor.LongQuoteBlocks, []}, {Credo.Check.Refactor.MatchInCondition, []}, diff --git a/lib/plausible_web/plugs/authorize_sites_api.ex b/extra/lib/plausible_web/authorize_sites_api.ex similarity index 100% rename from lib/plausible_web/plugs/authorize_sites_api.ex rename to extra/lib/plausible_web/authorize_sites_api.ex diff --git a/lib/plausible/billing/plans.ex b/lib/plausible/billing/plans.ex index 6d9fc0811..3d423348d 100644 --- a/lib/plausible/billing/plans.ex +++ b/lib/plausible/billing/plans.ex @@ -36,7 +36,6 @@ defmodule Plausible.Billing.Plans do As new versions of plans are introduced, users who were on old plans can still choose from old plans. """ - # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity def growth_plans_for(%User{} = user, now \\ Timex.now()) do user = Plausible.Users.with_subscription(user) v4_available = FunWithFlags.enabled?(:business_tier, for: user) diff --git a/lib/plausible/data_migration/numeric_ids.ex b/lib/plausible/data_migration/numeric_ids.ex index d6aaf5f20..e4b76e148 100644 --- a/lib/plausible/data_migration/numeric_ids.ex +++ b/lib/plausible/data_migration/numeric_ids.ex @@ -20,7 +20,6 @@ defmodule Plausible.DataMigration.NumericIDs do @table_settings "SETTINGS index_granularity = 8192" - # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity def run(opts \\ []) do interactive? = Keyword.get(opts, :interactive?, true) diff --git a/lib/plausible/ingestion/event.ex b/lib/plausible/ingestion/event.ex index ce04c8b5d..fd74f7b43 100644 --- a/lib/plausible/ingestion/event.ex +++ b/lib/plausible/ingestion/event.ex @@ -353,7 +353,7 @@ defmodule Plausible.Ingestion.Event do @tablet_types ["car browser", "tablet"] @desktop_types ["tv", "console", "desktop"] alias UAInspector.Result.Device - # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity + defp screen_size(ua) do case ua.device do %Device{type: t} when t in @mobile_types -> diff --git a/lib/plausible/plugins/api/token.ex b/lib/plausible/plugins/api/token.ex index 010cb83db..4330da0d9 100644 --- a/lib/plausible/plugins/api/token.ex +++ b/lib/plausible/plugins/api/token.ex @@ -71,7 +71,6 @@ defmodule Plausible.Plugins.API.Token do end @spec last_used_humanize(t()) :: String.t() - # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity def last_used_humanize(token) do diff = if token.last_used_at do diff --git a/lib/plausible/stats/base.ex b/lib/plausible/stats/base.ex index bed54eb5b..ecdb922ff 100644 --- a/lib/plausible/stats/base.ex +++ b/lib/plausible/stats/base.ex @@ -31,7 +31,6 @@ defmodule Plausible.Stats.Base do end end - # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity def query_events(site, query) do {first_datetime, last_datetime} = utc_boundaries(query, site) @@ -419,7 +418,6 @@ defmodule Plausible.Stats.Base do |> select_session_metrics(rest, query) end - # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity def dynamic_filter_condition(query, filter_key, db_field) do case query && query.filters && query.filters[filter_key] do {:is, value} -> diff --git a/lib/plausible/stats/clickhouse.ex b/lib/plausible/stats/clickhouse.ex index 1200f8eda..adefd1822 100644 --- a/lib/plausible/stats/clickhouse.ex +++ b/lib/plausible/stats/clickhouse.ex @@ -301,7 +301,6 @@ defmodule Plausible.Stats.Clickhouse do end end - # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity defp base_session_query(site, query) do {first_datetime, last_datetime} = utc_boundaries(query, site) @@ -421,7 +420,6 @@ defmodule Plausible.Stats.Clickhouse do end end - # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity defp base_query_bare(site, query) do {first_datetime, last_datetime} = utc_boundaries(query, site) diff --git a/lib/plausible/stats/filter_suggestions.ex b/lib/plausible/stats/filter_suggestions.ex index a0df834e3..e701d8459 100644 --- a/lib/plausible/stats/filter_suggestions.ex +++ b/lib/plausible/stats/filter_suggestions.ex @@ -177,7 +177,6 @@ defmodule Plausible.Stats.FilterSuggestions do |> wrap_suggestions() end - # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity def filter_suggestions(site, query, filter_name, filter_search) do filter_search = if filter_search == nil, do: "", else: filter_search diff --git a/lib/plausible/stats/filters.ex b/lib/plausible/stats/filters.ex index 621d7941c..67940f89a 100644 --- a/lib/plausible/stats/filters.ex +++ b/lib/plausible/stats/filters.ex @@ -54,7 +54,6 @@ defmodule Plausible.Stats.Filters do end @non_escaped_pipe_regex ~r/(? case metric do diff --git a/lib/plausible_web/components/billing.ex b/lib/plausible_web/components/billing.ex index 380e68c41..40acbecf7 100644 --- a/lib/plausible_web/components/billing.ex +++ b/lib/plausible_web/components/billing.ex @@ -15,7 +15,6 @@ defmodule PlausibleWeb.Components.Billing do attr(:size, :atom, default: :sm) attr(:rest, :global) - # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity def premium_feature_notice(assigns) do ~H""" <.notice @@ -37,7 +36,6 @@ defmodule PlausibleWeb.Components.Billing do attr(:resource, :string, required: true) attr(:rest, :global) - # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity def limit_exceeded_notice(assigns) do ~H""" <.notice {@rest} title="Notice"> diff --git a/lib/plausible_web/live/choose_plan.ex b/lib/plausible_web/live/choose_plan.ex index 7316b67c2..e187ee448 100644 --- a/lib/plausible_web/live/choose_plan.ex +++ b/lib/plausible_web/live/choose_plan.ex @@ -627,7 +627,6 @@ defmodule PlausibleWeb.Live.ChoosePlan do """ end - # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity defp change_plan_link_text( %{ owned_plan: %Plan{kind: from_kind, monthly_pageview_limit: from_volume},