Trim trailing whitespace from pathname

pull/1938/head
Uku Taht 5 years ago
parent e82131b2f3
commit 102ff1885e

@ -271,6 +271,7 @@ defmodule PlausibleWeb.Api.ExternalController do
pathname =
(uri.path || "/")
|> URI.decode()
|> String.trim_trailing()
if hash_mode && uri.fragment do
pathname <> "#" <> URI.decode(uri.fragment)

@ -141,6 +141,21 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
assert pageview.pathname == "/"
end
test "trailing whitespace is removed", %{conn: conn} do
params = %{
name: "pageview",
url: "http://www.example.com/path ",
domain: "external-controller-test-trailing-whitespace.com"
}
conn
|> post("/api/event", params)
pageview = get_event("external-controller-test-trailing-whitespace.com")
assert pageview.pathname == "/path"
end
test "bots and crawlers are ignored", %{conn: conn} do
params = %{
name: "pageview",

Loading…
Cancel
Save