diff --git a/lib/plausible_web/controllers/api/external_controller.ex b/lib/plausible_web/controllers/api/external_controller.ex index 870bb21b3..91f5e26f9 100644 --- a/lib/plausible_web/controllers/api/external_controller.ex +++ b/lib/plausible_web/controllers/api/external_controller.ex @@ -97,7 +97,7 @@ defmodule PlausibleWeb.Api.ExternalController do browser_version: (ua && browser_version(ua)) || "", screen_size: calculate_screen_size(params["screen_width"]) || "", "meta.key": Map.keys(params["meta"]), - "meta.value": Map.values(params["meta"]) + "meta.value": Map.values(params["meta"]) |> Enum.map(&Kernel.to_string/1) } changeset = Plausible.ClickhouseEvent.changeset(%Plausible.ClickhouseEvent{}, event_attrs) diff --git a/test/plausible_web/controllers/api/external_controller_test.exs b/test/plausible_web/controllers/api/external_controller_test.exs index bb882e8d2..3318574cf 100644 --- a/test/plausible_web/controllers/api/external_controller_test.exs +++ b/test/plausible_web/controllers/api/external_controller_test.exs @@ -391,6 +391,27 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do assert event.name == "custom event" end + test "casts custom props to string", %{conn: conn} do + params = %{ + name: "Signup", + url: "http://gigride.live/", + domain: "custom-prop-test.com", + props: Jason.encode!(%{ + bool_test: true, + number_test: 12 + }) + } + + conn + |> put_req_header("content-type", "text/plain") + |> post("/api/event", Jason.encode!(params)) + + event = get_event("custom-prop-test.com") + + assert Map.get(event, :"meta.key") == ["bool_test", "number_test"] + assert Map.get(event, :"meta.value") == ["true", "12"] + end + test "ignores a malformed referrer URL", %{conn: conn} do params = %{ name: "pageview",