From 1cc9a48ca115b7b206a8d96173b0cbb81fb87016 Mon Sep 17 00:00:00 2001 From: Karl-Aksel Puulmann Date: Mon, 19 Feb 2024 13:28:33 +0200 Subject: [PATCH] Refactor: Explicitly add field names to INSERT This avoids issues when code schema is out of sync with real schema --- lib/plausible/ingestion/write_buffer.ex | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/plausible/ingestion/write_buffer.ex b/lib/plausible/ingestion/write_buffer.ex index e62580cd5..1e33fe958 100644 --- a/lib/plausible/ingestion/write_buffer.ex +++ b/lib/plausible/ingestion/write_buffer.ex @@ -130,7 +130,8 @@ defmodule Plausible.Ingestion.WriteBuffer do |> Ch.RowBinary.encode_names_and_types(types) |> IO.iodata_to_binary() - insert_sql = "INSERT INTO #{schema.__schema__(:source)} FORMAT RowBinaryWithNamesAndTypes" + insert_sql = + "INSERT INTO #{schema.__schema__(:source)} (#{Enum.join(fields, ", ")}) FORMAT RowBinaryWithNamesAndTypes" %{ fields: fields,