From 1fc7442ad006cbed2982074017fc22ceff1a29ad Mon Sep 17 00:00:00 2001 From: Uku Taht Date: Mon, 13 Apr 2020 15:14:16 +0300 Subject: [PATCH] Don't set session if user isn't logged in --- lib/plausible_web/controllers/stats_controller.ex | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/plausible_web/controllers/stats_controller.ex b/lib/plausible_web/controllers/stats_controller.ex index f63699a50..d11817b2e 100644 --- a/lib/plausible_web/controllers/stats_controller.ex +++ b/lib/plausible_web/controllers/stats_controller.ex @@ -17,7 +17,7 @@ defmodule PlausibleWeb.StatsController do conn |> assign(:skip_plausible_tracking, !demo) - |> put_session(site.domain <> "_offer_email_report", nil) + |> remove_email_report_banner(site) |> put_resp_header("x-robots-tag", "noindex") |> render("stats.html", site: site, @@ -122,5 +122,13 @@ defmodule PlausibleWeb.StatsController do user -> Plausible.Sites.is_owner?(user.id, site) end end + + defp remove_email_report_banner(conn, site) do + if conn.assigns[:current_user] do + put_session(conn, site.domain <> "_offer_email_report", nil) + else + conn + end + end end