From 2259651b21758a41bef830acfc92284de97cc085 Mon Sep 17 00:00:00 2001 From: Uku Taht Date: Tue, 23 May 2023 11:35:18 +0300 Subject: [PATCH] Ignore missing subscription on update (#2930) --- lib/plausible/billing/billing.ex | 13 ++++++++----- test/plausible/billing/billing_test.exs | 20 ++++++++++++++++++++ 2 files changed, 28 insertions(+), 5 deletions(-) diff --git a/lib/plausible/billing/billing.ex b/lib/plausible/billing/billing.ex index f10d8fcb2..00ddfe343 100644 --- a/lib/plausible/billing/billing.ex +++ b/lib/plausible/billing/billing.ex @@ -201,11 +201,14 @@ defmodule Plausible.Billing do end defp handle_subscription_updated(params) do - Subscription - |> Repo.get_by!(paddle_subscription_id: params["subscription_id"]) - |> Subscription.changeset(format_subscription(params)) - |> Repo.update!() - |> after_subscription_update() + subscription = Repo.get_by(Subscription, paddle_subscription_id: params["subscription_id"]) + + if subscription do + subscription + |> Subscription.changeset(format_subscription(params)) + |> Repo.update!() + |> after_subscription_update() + end end defp handle_subscription_cancelled(params) do diff --git a/test/plausible/billing/billing_test.exs b/test/plausible/billing/billing_test.exs index c44567768..b8401a3ad 100644 --- a/test/plausible/billing/billing_test.exs +++ b/test/plausible/billing/billing_test.exs @@ -507,6 +507,26 @@ defmodule Plausible.BillingTest do assert Repo.reload!(site).locked == true assert Repo.reload!(user).grace_period.allowance_required == 11_000 end + + test "ignores if subscription cannot be found" do + user = insert(:user) + + res = + Billing.subscription_updated(%{ + "alert_name" => "subscription_updated", + "subscription_id" => "666", + "subscription_plan_id" => "new-plan-id", + "update_url" => "update_url.com", + "cancel_url" => "cancel_url.com", + "passthrough" => user.id, + "status" => "active", + "next_bill_date" => "2019-06-01", + "new_unit_price" => "12.00", + "currency" => "EUR" + }) + + assert res == {:ok, nil} + end end describe "subscription_cancelled" do