Trim trailing slash from referrer

pull/24/head
Uku Taht 7 years ago
parent b71e9bf5a5
commit 254d34d0a4

@ -74,7 +74,7 @@ defmodule PlausibleWeb.Api.ExternalController do
defp clean_referrer(referrer) do
uri = if referrer do
URI.parse(referrer)
URI.parse(String.trim_trailing(referrer, "/"))
end
if uri && uri.scheme in ["http", "https"] do

@ -116,6 +116,28 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
assert pageview.referrer_source == "Facebook"
end
test "strips trailing slash from referrer", %{conn: conn} do
params = %{
name: "pageview",
url: "http://gigride.live/",
referrer: "https://facebook.com/page/",
new_visitor: false,
uid: UUID.uuid4()
}
conn = conn
|> put_req_header("content-type", "text/plain")
|> put_req_header("user-agent", @user_agent)
|> post("/api/event", Jason.encode!(params))
pageview = Repo.one(Plausible.Event)
finalize_session(pageview.user_id)
assert response(conn, 202) == ""
assert pageview.referrer == "facebook.com/page"
assert pageview.referrer_source == "Facebook"
end
test "ignores when referrer is internal", %{conn: conn} do
params = %{
name: "pageview",

Loading…
Cancel
Save