Put front-end funnels behind a flag

pull/2859/head
Adam Rutkowski 4 years ago
parent 965dd394d0
commit 3d8ee2228d

@ -14,7 +14,7 @@ function Tabs({ tab, setTab, site }) {
return (
<div className="flex text-xs font-medium text-gray-500 dark:text-gray-400 space-x-2">
<div className={classNames({ [ACTIVE_CLASS]: tab == 'conversions', [DEFAULT_CLASS]: tab !== 'conversions' })} onClick={() => setTab('conversions')}>Conversions</div>
{FunnelTab({ tab, setTab, site })}
{site.flags.funnels && FunnelTab({ tab, setTab, site })}
</div>
)
}
@ -67,16 +67,21 @@ function FunnelTab({ tab, setTab, site }) {
export default function Behaviours({ query, site }) {
const [tab, setTab] = useState('conversions')
const tabs = <Tabs tab={tab} setTab={setTab} site={site} />
const selectedFunnel = site.funnels.find(funnel => funnel.name === tab)
const funnelNames = site.funnels.map(({ name }) => name)
if (site.flags.funnels) {
const selectedFunnel = site.funnels.find(funnel => funnel.name === tab)
const funnelNames = site.funnels.map(({ name }) => name)
return (
<div className="w-full p-4 bg-white rounded shadow-xl dark:bg-gray-825">
return (
<div className="w-full p-4 bg-white rounded shadow-xl dark:bg-gray-825">
{tab == 'conversions' && <Conversions tabs={tabs} query={query} site={site} />}
{funnelNames.includes(tab) && <Funnel tabs={tabs} funnel={selectedFunnel} query={query} site={site} />}
</div>
)
} else {
return <div className="w-full p-4 bg-white rounded shadow-xl dark:bg-gray-825">
{tab == 'conversions' && <Conversions tabs={tabs} query={query} site={site} />}
{funnelNames.includes(tab) && <Funnel tabs={tabs} funnel={selectedFunnel} query={query} site={site} />}
</div>
)
}
}

@ -330,7 +330,8 @@ defmodule PlausibleWeb.StatsController do
defp get_flags(user) do
%{
custom_dimension_filter: FunWithFlags.enabled?(:custom_dimension_filter, for: user),
views_per_visit_metric: FunWithFlags.enabled?(:views_per_visit_metric, for: user)
views_per_visit_metric: FunWithFlags.enabled?(:views_per_visit_metric, for: user),
funnels: FunWithFlags.enabled?(:funnels, for: user)
}
end

Loading…
Cancel
Save