From 425975efec28d348ec4c853d4eec96dfa68e5692 Mon Sep 17 00:00:00 2001 From: Vignesh Joglekar Date: Wed, 16 Dec 2020 03:57:28 -0600 Subject: [PATCH] Adds dark mode to entire dashboard (#467) * Adds New Dark Mode Assets * Moves triangle for dropdown to a reasonable position * Majority .eex dark implementation * Fixes Logo Positioning * Adds theme flag to user schema, uses it * Uses correct variables for theme applicator script * Minor missed theme changes/fallbacks * Individual Component Support + Theme Context * Sources Tab Support This was a pain to test D: * Partial Stats Sections Support * More of stats modules supported * Modal +table support * Improves some Flatpickr in light theme, supports dark theme * Fixes missed settings tab colors * Finishes Devices module support * Fixes bar graph colors * Better colorizes maps module * Undoes colorized bars (they looked bad, on second thought) * Fixes loading indicator * Finishes conversions module * Adds changelog entry The PR number could be wrong, will double check * Fixes missed header color * Fixes naming of migration and removes static alter * Does migration correctly As I said, my Elixir is pretty weak heh * Adds support for spike notifications setting * Improves contrast and visibility for email settings * Resolves @ukutaht's comments on #467 * Fixes missing dark style * Found one more missed dark element (shared links) * Formatting fixes --- CHANGELOG.md | 1 + assets/css/app.css | 18 ++- assets/css/flatpickr.dark.css | 110 ++++++++++++++++++ assets/css/loader.css | 5 + assets/js/dashboard/datepicker.js | 22 ++-- assets/js/dashboard/error-boundary.js | 2 +- assets/js/dashboard/filters.js | 2 +- assets/js/dashboard/index.js | 4 +- assets/js/dashboard/site-switcher.js | 18 +-- .../js/dashboard/stats/conversions/index.js | 14 +-- .../stats/conversions/prop-breakdown.js | 16 +-- assets/js/dashboard/stats/countries.js | 39 +++++-- assets/js/dashboard/stats/current-visitors.js | 2 +- assets/js/dashboard/stats/devices/browsers.js | 10 +- assets/js/dashboard/stats/devices/index.js | 18 +-- .../stats/devices/operating-systems.js | 10 +- assets/js/dashboard/stats/modals/countries.js | 10 +- .../dashboard/stats/modals/google-keywords.js | 22 ++-- assets/js/dashboard/stats/modals/modal.js | 2 +- assets/js/dashboard/stats/modals/pages.js | 12 +- .../stats/modals/referrer-drilldown.js | 32 ++--- assets/js/dashboard/stats/modals/sources.js | 14 +-- assets/js/dashboard/stats/more-link.js | 2 +- assets/js/dashboard/stats/pages.js | 16 +-- .../dashboard/stats/sources/referrer-list.js | 16 +-- .../dashboard/stats/sources/search-terms.js | 18 +-- .../js/dashboard/stats/sources/source-list.js | 30 ++--- assets/js/dashboard/stats/visitor-graph.js | 41 +++++-- assets/js/dashboard/theme-consumer-hoc.js | 16 +++ assets/js/dashboard/theme-context.js | 5 + assets/js/dashboard/theme-provider-hoc.js | 37 ++++++ .../images/icon/plausible_logo_100px_dark.png | Bin 0 -> 12099 bytes .../images/icon/plausible_logo_300px_dark.png | Bin 0 -> 34478 bytes .../images/icon/plausible_logo_dark.png | Bin 0 -> 13385 bytes assets/static/js/applyTheme.js | 37 ++++++ assets/tailwind.config.js | 15 ++- lib/plausible/auth/user.ex | 3 +- lib/plausible/themes.ex | 11 ++ .../controllers/auth_controller.ex | 3 +- .../templates/auth/_onboarding_steps.html.eex | 14 +-- .../templates/auth/activate.html.eex | 18 +-- .../templates/auth/login_form.html.eex | 16 +-- .../templates/auth/password_form.html.eex | 12 +- .../auth/password_reset_form.html.eex | 12 +- .../auth/password_reset_request_form.html.eex | 8 +- .../password_reset_request_success.html.eex | 12 +- .../templates/auth/register_form.html.eex | 28 ++--- .../templates/auth/register_success.html.eex | 12 +- .../templates/auth/user_settings.html.eex | 80 +++++++------ .../templates/billing/change_plan.html.eex | 68 +++++------ .../billing/change_plan_preview.html.eex | 38 +++--- .../templates/billing/upgrade.html.eex | 70 +++++------ .../billing/upgrade_success.html.eex | 6 +- .../templates/error/error.html.eex | 8 +- .../templates/layout/_flash.html.eex | 16 +-- .../templates/layout/_footer.html.eex | 2 +- .../templates/layout/_settings_tab.html.eex | 4 +- .../templates/layout/app.html.eex | 28 +++-- .../templates/layout/focus.html.eex | 6 +- .../templates/layout/site_settings.html.eex | 6 +- .../templates/page/index.html.eex | 2 +- .../site/custom_domain_dns_setup.html.eex | 16 +-- .../site/custom_domain_snippet.html.eex | 16 +-- .../templates/site/index.html.eex | 18 +-- lib/plausible_web/templates/site/new.html.eex | 16 +-- .../templates/site/new_custom_domain.html.eex | 12 +- .../templates/site/new_goal.html.eex | 30 ++--- .../templates/site/new_shared_link.html.eex | 10 +- .../site/settings_custom_domain.html.eex | 14 ++- .../site/settings_danger_zone.html.eex | 20 ++-- .../site/settings_email_reports.html.eex | 62 +++++----- .../templates/site/settings_general.html.eex | 26 ++--- .../templates/site/settings_goals.html.eex | 12 +- .../site/settings_search_console.html.eex | 18 +-- .../site/settings_visibility.html.eex | 28 ++--- .../templates/site/snippet.html.eex | 8 +- .../stats/shared_link_password.html.eex | 10 +- .../templates/stats/stats.html.eex | 6 +- .../stats/waiting_first_pageview.html.eex | 10 +- .../templates/unsubscribe/success.html.eex | 6 +- ...20201214072008_add_theme_pref_to_users.exs | 9 ++ 81 files changed, 884 insertions(+), 562 deletions(-) create mode 100644 assets/css/flatpickr.dark.css create mode 100644 assets/js/dashboard/theme-consumer-hoc.js create mode 100644 assets/js/dashboard/theme-context.js create mode 100644 assets/js/dashboard/theme-provider-hoc.js create mode 100644 assets/static/images/icon/plausible_logo_100px_dark.png create mode 100644 assets/static/images/icon/plausible_logo_300px_dark.png create mode 100644 assets/static/images/icon/plausible_logo_dark.png create mode 100644 assets/static/js/applyTheme.js create mode 100644 lib/plausible/themes.ex create mode 100644 priv/repo/migrations/20201214072008_add_theme_pref_to_users.exs diff --git a/CHANGELOG.md b/CHANGELOG.md index 6f988bc44..5048fab9a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ All notable changes to this project will be documented in this file. - Display weekday on the visitor graph plausible/analytics#175 - Collect and display browser & OS versions plausible/analytics#397 - Simple notifications around traffic spikes plausible/analytics#453 +- Dark theme option/system setting follow plausible/analytics#467 ### Changed - Use alpine as base image to decrease Docker image size plausible/analytics#353 diff --git a/assets/css/app.css b/assets/css/app.css index 69a4d122d..c9eeda96e 100644 --- a/assets/css/app.css +++ b/assets/css/app.css @@ -5,6 +5,7 @@ @import "modal.css"; @import "loader.css"; @import "tooltip.css"; +@import "flatpickr.dark.css"; .button { @apply bg-indigo-600 border border-transparent rounded-md py-2 px-4 inline-flex justify-center text-sm leading-5 font-medium text-white transition hover:bg-indigo-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-indigo-500; @@ -156,7 +157,7 @@ blockquote { .dropdown-content::before { top: -16px; - right: 64px; + right: 8px; left: auto; } .dropdown-content::before { @@ -174,7 +175,7 @@ blockquote { } .dropdown-content::after { top: -14px; - right: 65px; + right: 9px; left: auto; } @@ -196,6 +197,14 @@ blockquote { background-color: #f1f5f8; } +.dark .table-striped tbody tr:nth-child(odd) { + background-color: rgb(37, 47, 63); +} + +.dark .table-striped tbody tr:nth-child(even) { + background-color: rgb(26, 32, 44); +} + .twitter-icon { width: 1.25em; height: 1.25em; @@ -252,3 +261,8 @@ blockquote { .datamaps-subunit { cursor: pointer; } + +/* Only because the map handler doesn't expose an easier way to change the shadow color */ +.dark .hoverinfo { + box-shadow: 1px 1px 5px rgb(26, 32, 44); +} diff --git a/assets/css/flatpickr.dark.css b/assets/css/flatpickr.dark.css new file mode 100644 index 000000000..a4b6ad03e --- /dev/null +++ b/assets/css/flatpickr.dark.css @@ -0,0 +1,110 @@ +/* Because Flatpickr offers zero support for dynamic theming on its own (outside of third-party plugins) */ +.dark .flatpickr-calendar { + background-color: #1f2937; +} + +.dark .flatpickr-weekday { + color: #f3f4f6; +} + +.dark .flatpickr-prev-month { + fill: #f3f4f6 !important; +} + +.dark .flatpickr-next-month { + fill: #f3f4f6 !important; +} + +.dark .flatpickr-monthDropdown-months { + color: #f3f4f6 !important; +} + +.dark .numInputWrapper { + color: #f3f4f6; +} + +.dark .flatpickr-day.prevMonthDay { + color: #94a3af; +} + +.dark .flatpickr-day { + color: #E5E7EB; +} + +.dark .flatpickr-day.prevMonthDay { + color: #9CA3AF; +} + +.dark .flatpickr-day.nextMonthDay { + color: #9CA3AF; +} + +.dark .flatpickr-day:hover { + background-color: #374151; +} + +.dark :not(.startRange):not(.endRange).flatpickr-day.nextMonthDay:hover { + background-color: #374151; +} + +.dark :not(.startRange):not(.endRange).flatpickr-day.prevMonthDay:hover { + background-color: #374151; +} + +.dark .flatpickr-next-month { + fill: #f3f4f6; +} + +.dark .flatpickr-day.flatpickr-disabled { + color: #4B5563; +} + +.dark .flatpickr-day.flatpickr-disabled:hover { + color: #4B5563; +} + +.dark .flatpickr-day.today { + background-color: rgba(167, 243, 208, 0.5); +} + +.dark .flatpickr-day.today { + border-color: #34D399; +} + +.dark .flatpickr-day.inRange { + background-color: #374151; + box-shadow: -5px 0 0 #374151,5px 0 0 #374151; + border-color: #374151; +} + +.dark .flatpickr-day.prevMonthDay.inRange { + background-color: #374151; + box-shadow: -5px 0 0 #374151,5px 0 0 #374151; + border-color: #374151; +} + +.dark .flatpickr-day.nextMonthDay.inRange { + background-color: #374151; + box-shadow: -5px 0 0 #374151,5px 0 0 #374151; + border-color: #374151; +} + +.flatpickr-day.startRange { + background: #6574cd !important; + border-color: #6574cd !important; +} + +.flatpickr-day.endRange { + background: #6574cd !important; + border-color: #6574cd !important; +} + +.dark .flatpickr-day.selected.startRange + .endRange:not(:nth-child(7n+1)), .flatpickr-day.startRange.startRange + .endRange:not(:nth-child(7n+1)), .flatpickr-day.endRange.startRange + .endRange:not(:nth-child(7n+1)) { + -webkit-box-shadow: -10px 0 0 #4556c3 !important; + box-shadow: -10px 0 0 #4556c3 !important; +} + +.flatpickr-day.selected.startRange + .endRange:not(:nth-child(7n+1)), .flatpickr-day.startRange.startRange + .endRange:not(:nth-child(7n+1)), .flatpickr-day.endRange.startRange + .endRange:not(:nth-child(7n+1)) { + -webkit-box-shadow: -10px 0 0 #4556c3 !important; + box-shadow: -10px 0 0 #4556c3 !important; +} diff --git a/assets/css/loader.css b/assets/css/loader.css index 38af0f968..a5dc562f1 100644 --- a/assets/css/loader.css +++ b/assets/css/loader.css @@ -20,6 +20,11 @@ -webkit-animation: spin 1s ease-in-out infinite; } +.dark .loading div { + border: 3px solid #606f7b; + border-top-color: #dae1e7; +} + .loading.sm div { width: 25px; height: 25px; diff --git a/assets/js/dashboard/datepicker.js b/assets/js/dashboard/datepicker.js index 5f6d74726..a45210127 100644 --- a/assets/js/dashboard/datepicker.js +++ b/assets/js/dashboard/datepicker.js @@ -101,11 +101,11 @@ class DatePicker extends React.Component { renderArrow(period, prevDate, nextDate) { return ( -
- +
+ - +
@@ -135,7 +135,7 @@ class DatePicker extends React.Component { renderDropDown() { return (
this.dropDownNode = node}> -
+
{this.timeFrameText()} @@ -176,7 +176,7 @@ class DatePicker extends React.Component { if (opts.date) { opts.date = formatISO(opts.date) } return ( - + {text} ) @@ -186,29 +186,29 @@ class DatePicker extends React.Component { if (this.state.mode === 'menu') { return (
-
+
{ this.renderLink('day', 'Today') } { this.renderLink('realtime', 'Realtime') }
-
+
{ this.renderLink('7d', 'Last 7 days') } { this.renderLink('30d', 'Last 30 days') }
-
+
{ this.renderLink('month', 'This month') } { this.renderLink('month', 'Last month', {date: lastMonth(this.props.site)}) }
-
+
{ this.renderLink('6mo', 'Last 6 months') } { this.renderLink('12mo', 'Last 12 months') }
-
+
- this.setState({mode: 'calendar'}, this.openCalendar.bind(this))} className="block px-4 py-2 text-sm leading-tight hover:bg-gray-100 hover:text-gray-900 cursor-pointer">Custom range + this.setState({mode: 'calendar'}, this.openCalendar.bind(this))} className="block px-4 py-2 text-sm leading-tight hover:bg-gray-100 dark:hover:bg-gray-900 hover:text-gray-900 dark:hover:text-gray-100 cursor-pointer">Custom range
diff --git a/assets/js/dashboard/error-boundary.js b/assets/js/dashboard/error-boundary.js index e10fdccc5..b09ae8b3f 100644 --- a/assets/js/dashboard/error-boundary.js +++ b/assets/js/dashboard/error-boundary.js @@ -14,7 +14,7 @@ export default class ErrorBoundary extends React.Component { render() { if (this.state.error) { return ( -
+
Oops! Something went wrong
{this.state.error.name + ': ' + this.state.error.message}
diff --git a/assets/js/dashboard/filters.js b/assets/js/dashboard/filters.js index 5319579d4..032d7852a 100644 --- a/assets/js/dashboard/filters.js +++ b/assets/js/dashboard/filters.js @@ -68,7 +68,7 @@ function renderFilter(history, [key, value], query) { } return ( - + {filterText(key, value, query)} ✕ ) diff --git a/assets/js/dashboard/index.js b/assets/js/dashboard/index.js index 5b0e37e86..d5143d90f 100644 --- a/assets/js/dashboard/index.js +++ b/assets/js/dashboard/index.js @@ -5,7 +5,7 @@ import Historical from './historical' import Realtime from './realtime' import {parseQuery} from './query' import * as api from './api' - +import { withThemeProvider } from './theme-provider-hoc'; const THIRTY_SECONDS = 30000 @@ -51,4 +51,4 @@ class Dashboard extends React.Component { } } -export default withRouter(Dashboard) +export default withRouter(withThemeProvider(Dashboard)) diff --git a/assets/js/dashboard/site-switcher.js b/assets/js/dashboard/site-switcher.js index 2ebf661c5..0ac34d3e9 100644 --- a/assets/js/dashboard/site-switcher.js +++ b/assets/js/dashboard/site-switcher.js @@ -45,9 +45,9 @@ export default class SiteSwitcher extends React.Component { } renderSiteLink(domain) { - const extraClass = domain === this.props.site.domain ? 'font-medium text-gray-900' : 'hover:bg-gray-100 hover:text-gray-900 focus:outline-none focus:bg-gray-100 focus:text-gray-900' + const extraClass = domain === this.props.site.domain ? 'font-medium text-gray-900 dark:text-gray-100' : 'hover:bg-gray-100 dark:hover:bg-gray-900 hover:text-gray-900 dark:hover:text-gray-100 focus:outline-none focus:bg-gray-100 dark:focus:bg-gray-900 focus:text-gray-900 dark:focus:text-gray-100' return ( - + {domain} @@ -58,17 +58,17 @@ export default class SiteSwitcher extends React.Component { if (this.state.loading) { return
} else if (this.state.error) { - return
Something went wrong, try again
+ return
Something went wrong, try again
} else { return ( -
+
{ this.state.sites.map(this.renderSiteLink.bind(this)) }
@@ -88,11 +88,11 @@ export default class SiteSwitcher extends React.Component { } render() { - const hoverClass = this.props.loggedIn ? 'hover:text-gray-500 focus:border-blue-300 focus:ring ' : 'cursor-default' + const hoverClass = this.props.loggedIn ? 'hover:text-gray-500 dark:hover:text-gray-200 focus:border-blue-300 focus:ring ' : 'cursor-default' return (
-