From 4654a5036587b583fbef269cd06653133d802552 Mon Sep 17 00:00:00 2001 From: Adam Date: Wed, 15 Mar 2023 13:13:46 +0100 Subject: [PATCH] Revert "Fail CI when tests are logging (#2748)" (#2758) This reverts commit 05d14774be83998d57446c06c949e68cc2025ac8. --- .github/bin/log-watch.sh | 20 -------------------- .github/workflows/elixir.yml | 2 +- 2 files changed, 1 insertion(+), 21 deletions(-) delete mode 100755 .github/bin/log-watch.sh diff --git a/.github/bin/log-watch.sh b/.github/bin/log-watch.sh deleted file mode 100755 index 046481353..000000000 --- a/.github/bin/log-watch.sh +++ /dev/null @@ -1,20 +0,0 @@ -#!/bin/sh -fail=false -while read l -do - echo "$l" - if echo "$l" | grep -qP '\[(warning|error)\]' - then - fail=true; - fi -done - -if [ $fail = true ] -then - echo - echo "💀 The tests are logging, please capture logs. See:" - echo " - https://hexdocs.pm/ex_unit/1.12/ExUnit.CaptureLog.html" - echo " - https://hexdocs.pm/ex_unit/1.12/ExUnit.Case.html#module-known-tags" - echo - exit 1 -fi diff --git a/.github/workflows/elixir.yml b/.github/workflows/elixir.yml index 444fecd84..540b8a47c 100644 --- a/.github/workflows/elixir.yml +++ b/.github/workflows/elixir.yml @@ -71,7 +71,7 @@ jobs: - name: Check Credo Warnings run: mix credo diff --from-git-merge-base origin/master - name: Run tests - run: mix test --include slow --max-failures 1 --warnings-as-errors | .github/bin/log-watch.sh + run: mix test --include slow --max-failures 1 --warnings-as-errors - name: Check Dialyzer run: mix dialyzer env: