Rotate salts on a daily basis (#224)
* Add daily salt rotation for user ids * Rotate salts on a cron schedule daily * Keep old salt fo 48 hours * Double write for plausible.io to test salt rotation * Rotate salts for every sitepull/225/head
parent
0054904ede
commit
4d55c4657a
@ -0,0 +1,46 @@
|
||||
defmodule Plausible.Session.Salts do
|
||||
use Agent
|
||||
use Plausible.Repo
|
||||
|
||||
def start_link(_opts) do
|
||||
Agent.start_link(fn ->
|
||||
clean_old_salts()
|
||||
salts = Repo.all(from s in "salts", select: s.salt, order_by: [desc: s.inserted_at], limit: 2)
|
||||
case salts do
|
||||
[current, prev] ->
|
||||
%{previous: prev, current: current}
|
||||
[current] ->
|
||||
%{previous: nil, current: current}
|
||||
[] ->
|
||||
new = generate_and_persist_new_salt()
|
||||
%{previous: nil, current: new}
|
||||
end
|
||||
end, name: __MODULE__)
|
||||
end
|
||||
|
||||
def fetch() do
|
||||
Agent.get(__MODULE__, & &1)
|
||||
end
|
||||
|
||||
def rotate() do
|
||||
Agent.update(__MODULE__, fn %{current: current} ->
|
||||
clean_old_salts()
|
||||
|
||||
%{
|
||||
current: generate_and_persist_new_salt(),
|
||||
previous: current
|
||||
}
|
||||
end)
|
||||
end
|
||||
|
||||
defp generate_and_persist_new_salt() do
|
||||
salt = :crypto.strong_rand_bytes(16)
|
||||
|
||||
Repo.insert_all("salts", [%{salt: salt, inserted_at: Timex.now()}])
|
||||
salt
|
||||
end
|
||||
|
||||
defp clean_old_salts() do
|
||||
Repo.delete_all(from s in "salts", where: s.inserted_at < fragment("now() - '48 hours'::interval"))
|
||||
end
|
||||
end
|
||||
@ -0,0 +1,9 @@
|
||||
defmodule Plausible.Workers.RotateSalts do
|
||||
use Plausible.Repo
|
||||
use Oban.Worker, queue: :rotate_salts
|
||||
|
||||
@impl Oban.Worker
|
||||
def perform(_args, _job) do
|
||||
Plausible.Session.Salts.rotate()
|
||||
end
|
||||
end
|
||||
@ -0,0 +1,11 @@
|
||||
defmodule Plausible.Repo.Migrations.CreateSaltsTable do
|
||||
use Ecto.Migration
|
||||
|
||||
def change do
|
||||
create table(:salts) do
|
||||
add :salt, :bytea, null: false
|
||||
|
||||
timestamps(updated_at: false)
|
||||
end
|
||||
end
|
||||
end
|
||||
Loading…
Reference in New Issue