From 4ffb25dcaf57f3fea8ca65d0167480c4cb3878ac Mon Sep 17 00:00:00 2001 From: Karl-Aksel Puulmann Date: Tue, 2 Apr 2024 14:58:36 +0300 Subject: [PATCH] Dont filter by session properties on events table if querying sessions and joining in events --- lib/plausible/stats/base.ex | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/lib/plausible/stats/base.ex b/lib/plausible/stats/base.ex index 4d0726abf..d55b4fd6c 100644 --- a/lib/plausible/stats/base.ex +++ b/lib/plausible/stats/base.ex @@ -30,7 +30,11 @@ defmodule Plausible.Stats.Base do on: e.session_id == sq.session_id ) else - events_q + if query.experimental_reduced_joins? do + events_q |> filter_by_visit_props(Filters.event_table_visit_props(), query) + else + events_q + end end end @@ -119,14 +123,6 @@ defmodule Plausible.Stats.Base do &filter_by_custom_prop/2 ) - # :TODO: Maybe check if joined and no filter needed - q = - if query.experimental_reduced_joins? do - filter_by_visit_props(q, Filters.event_table_visit_props(), query) - else - q - end - q end