Allow super-admin Stats API access for locked sites (#2308)

pull/2316/head
Adam Rutkowski 4 years ago committed by GitHub
parent ceff6e17b2
commit 523b114682
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -57,9 +57,9 @@ defmodule PlausibleWeb.AuthorizeStatsApiPlug do
is_super_admin? = Plausible.Auth.is_super_admin?(api_key.user_id)
cond do
is_super_admin? -> {:ok, site}
Sites.locked?(site) -> {:error, :site_locked}
is_member? -> {:ok, site}
is_super_admin? -> {:ok, site}
true -> {:error, :invalid_api_key}
end

@ -67,7 +67,7 @@ defmodule PlausibleWeb.Api.ExternalStatsController.AuthTest do
})
end
describe "admin access" do
describe "super admin access" do
setup %{user: user} do
original_env = Application.get_env(:plausible, :super_admin_user_ids)
Application.put_env(:plausible, :super_admin_user_ids, [user.id])
@ -77,7 +77,7 @@ defmodule PlausibleWeb.Api.ExternalStatsController.AuthTest do
end)
end
test "can access as an admin", %{conn: conn, api_key: api_key} do
test "can access as a super admin", %{conn: conn, api_key: api_key} do
site = insert(:site)
conn
@ -87,6 +87,22 @@ defmodule PlausibleWeb.Api.ExternalStatsController.AuthTest do
"results" => %{"pageviews" => %{"value" => 0}}
})
end
test "can access as a super admin even if site is locked", %{
conn: conn,
api_key: api_key,
user: user
} do
site = insert(:site, members: [user])
{1, _} = Plausible.Billing.SiteLocker.set_lock_status_for(user, true)
conn
|> with_api_key(api_key)
|> get("/api/v1/stats/aggregate", %{"site_id" => site.domain, "metrics" => "pageviews"})
|> assert_ok(%{
"results" => %{"pageviews" => %{"value" => 0}}
})
end
end
test "limits the rate of API requests", %{user: user} do

Loading…
Cancel
Save