From 52d5fac362ff3ad1ad995c42844a629bc19ce516 Mon Sep 17 00:00:00 2001 From: hq1 Date: Tue, 17 Oct 2023 16:07:06 +0200 Subject: [PATCH] Fixup 4cdf843ad: (#3434) - migration is irreversible for now, likely due to https://github.com/plausible/ecto_ch/issues/81#issuecomment-1624754909 or maybe https://github.com/plausible/ecto_ch/pull/58/files - IO.inspect call removed --- ...sable_deduplication_window_for_imports.exs | 31 ++++++++++--------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/priv/ingest_repo/migrations/20231017073642_disable_deduplication_window_for_imports.exs b/priv/ingest_repo/migrations/20231017073642_disable_deduplication_window_for_imports.exs index 944a900df..f462786b3 100644 --- a/priv/ingest_repo/migrations/20231017073642_disable_deduplication_window_for_imports.exs +++ b/priv/ingest_repo/migrations/20231017073642_disable_deduplication_window_for_imports.exs @@ -2,33 +2,34 @@ defmodule Plausible.IngestRepo.Migrations.DisableDeduplicationWindowForImports d use Ecto.Migration @import_tables ~w( - imported_visitors - imported_sources - imported_pages - imported_entry_pages - imported_exit_pages - imported_locations - imported_devices - imported_browsers + imported_visitors + imported_sources + imported_pages + imported_entry_pages + imported_exit_pages + imported_locations + imported_devices + imported_browsers imported_operating_systems ) - def change do + def up do cluster_query = "SELECT 1 FROM system.replicas WHERE table = 'imported_visitors'" cluster? = - case Ecto.Adapters.SQL.query(Plausible.IngestRepo, cluster_query) |> IO.inspect() do + case Ecto.Adapters.SQL.query(Plausible.IngestRepo, cluster_query) do {:ok, %{rows: []}} -> false {:ok, _} -> true end for table <- @import_tables do execute """ - ALTER TABLE #{table} #{if cluster?, do: "ON CLUSTER '{cluster}'"} MODIFY SETTING replicated_deduplication_window = 0 - """, - """ - ALTER TABLE #{table} #{if cluster?, do: "ON CLUSTER '{cluster}'"} MODIFY SETTING replicated_deduplication_window = 100 - """ + ALTER TABLE #{table} #{if cluster?, do: "ON CLUSTER '{cluster}'"} MODIFY SETTING replicated_deduplication_window = 0 + """ end end + + def down do + raise "Irreversible" + end end