From 6228995d4fbe27a49bb4c41f9d60942632bc4ec1 Mon Sep 17 00:00:00 2001 From: Uku Taht Date: Tue, 25 May 2021 11:32:54 +0300 Subject: [PATCH] Rate limit login attempts to 5 per minute --- config/runtime.exs | 3 + .../controllers/auth_controller.ex | 90 +++++++++++++------ mix.exs | 3 +- mix.lock | 1 + .../controllers/auth_controller_test.exs | 32 +++++++ 5 files changed, 102 insertions(+), 27 deletions(-) diff --git a/config/runtime.exs b/config/runtime.exs index f1f489d14..2d6383fbc 100644 --- a/config/runtime.exs +++ b/config/runtime.exs @@ -250,6 +250,9 @@ config :plausible, :user_agent_cache, limit: user_agent_cache_limit, stats: user_agent_cache_stats +config :hammer, + backend: {Hammer.Backend.ETS, [expiry_ms: 60_000 * 60 * 4, cleanup_interval_ms: 60_000 * 10]} + config :kaffy, otp_app: :plausible, ecto_repo: Plausible.Repo, diff --git a/lib/plausible_web/controllers/auth_controller.ex b/lib/plausible_web/controllers/auth_controller.ex index ab8d85bdc..793ce2f2a 100644 --- a/lib/plausible_web/controllers/auth_controller.ex +++ b/lib/plausible_web/controllers/auth_controller.ex @@ -227,41 +227,79 @@ defmodule PlausibleWeb.AuthController do end def login(conn, %{"email" => email, "password" => password}) do - alias Plausible.Auth.Password + with :ok <- check_ip_rate_limit(conn), + {:ok, user} <- find_user(email), + :ok <- check_user_rate_limit(user), + :ok <- check_password(user, password) do + login_dest = get_session(conn, :login_dest) || "/sites" - user = - Repo.one( - from u in Plausible.Auth.User, - where: u.email == ^email + conn + |> put_session(:current_user_id, user.id) + |> put_resp_cookie("logged_in", "true", + http_only: false, + max_age: 60 * 60 * 24 * 365 * 5000 ) + |> put_session(:login_dest, nil) + |> redirect(to: login_dest) + else + :wrong_password -> + render(conn, "login_form.html", + error: "Wrong email or password. Please try again.", + layout: {PlausibleWeb.LayoutView, "focus.html"} + ) - if user do - if Password.match?(password, user.password_hash || "") do - login_dest = get_session(conn, :login_dest) || "/sites" + :user_not_found -> + Plausible.Auth.Password.dummy_calculation() - conn - |> put_session(:current_user_id, user.id) - |> put_resp_cookie("logged_in", "true", - http_only: false, - max_age: 60 * 60 * 24 * 365 * 5000 - ) - |> put_session(:login_dest, nil) - |> redirect(to: login_dest) - else - conn - |> render("login_form.html", + render(conn, "login_form.html", error: "Wrong email or password. Please try again.", layout: {PlausibleWeb.LayoutView, "focus.html"} ) - end - else - Password.dummy_calculation() - conn - |> render("login_form.html", - error: "Wrong email or password. Please try again.", - layout: {PlausibleWeb.LayoutView, "focus.html"} + {:rate_limit, wat} -> + IO.inspect(wat) + + render_error( + conn, + 429, + "Too many login attempts. Wait a minute before trying again." + ) + end + end + + @login_interval 60_000 + @login_limit 5 + defp check_ip_rate_limit(conn) do + ip_address = PlausibleWeb.RemoteIp.get(conn) + + case Hammer.check_rate("login:ip:#{ip_address}", @login_interval, @login_limit) do + {:allow, _} -> :ok + {:deny, _} -> {:rate_limit, :ip_address} + end + end + + defp find_user(email) do + user = + Repo.one( + from u in Plausible.Auth.User, + where: u.email == ^email ) + + if user, do: {:ok, user}, else: :user_not_found + end + + defp check_user_rate_limit(user) do + case Hammer.check_rate("login:user:#{user.id}", @login_interval, @login_limit) do + {:allow, _} -> :ok + {:deny, _} -> {:rate_limit, :user} + end + end + + defp check_password(user, password) do + if Plausible.Auth.Password.match?(password, user.password_hash || "") do + :ok + else + :wrong_password end end diff --git a/mix.exs b/mix.exs index d8742f91e..6ba5e37fe 100644 --- a/mix.exs +++ b/mix.exs @@ -95,7 +95,8 @@ defmodule Plausible.MixProject do {:credo, "~> 1.5", only: [:dev, :test], runtime: false}, {:kaffy, "~> 0.9.0"}, {:envy, "~> 1.1.1"}, - {:phoenix_pagination, "~> 0.7.0"} + {:phoenix_pagination, "~> 0.7.0"}, + {:hammer, "~> 6.0"} ] end diff --git a/mix.lock b/mix.lock index 73174ccdd..f34cb0a6c 100644 --- a/mix.lock +++ b/mix.lock @@ -44,6 +44,7 @@ "geolix_adapter_mmdb2": {:hex, :geolix_adapter_mmdb2, "0.5.0", "5912723d9538ecddc6b29b1d8041b917b735a78fd3c122bfea8c44aa782e3369", [:mix], [{:geolix, "~> 1.1", [hex: :geolix, repo: "hexpm", optional: false]}, {:mmdb2_decoder, "~> 3.0", [hex: :mmdb2_decoder, repo: "hexpm", optional: false]}], "hexpm", "cb1485b6a0a2d3e541949207428a245718dbf1258453a0df0e5fdd925bcecd3e"}, "gettext": {:hex, :gettext, "0.18.2", "7df3ea191bb56c0309c00a783334b288d08a879f53a7014341284635850a6e55", [:mix], [], "hexpm", "f9f537b13d4fdd30f3039d33cb80144c3aa1f8d9698e47d7bcbcc8df93b1f5c5"}, "hackney": {:hex, :hackney, "1.17.4", "99da4674592504d3fb0cfef0db84c3ba02b4508bae2dff8c0108baa0d6e0977c", [:rebar3], [{:certifi, "~>2.6.1", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "~>6.1.0", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "~>1.0.0", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "~>1.1", [hex: :mimerl, repo: "hexpm", optional: false]}, {:parse_trans, "3.3.1", [hex: :parse_trans, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "~>1.1.0", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}, {:unicode_util_compat, "~>0.7.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm", "de16ff4996556c8548d512f4dbe22dd58a587bf3332e7fd362430a7ef3986b16"}, + "hammer": {:hex, :hammer, "6.0.0", "72ec6fff10e9d63856968988a22ee04c4d6d5248071ddccfbda50aa6c455c1d7", [:mix], [{:poolboy, "~> 1.5", [hex: :poolboy, repo: "hexpm", optional: false]}], "hexpm", "d8e1ec2e534c4aae508b906759e077c3c1eb3e2b9425235d4b7bbab0b016210a"}, "httpoison": {:hex, :httpoison, "1.8.0", "6b85dea15820b7804ef607ff78406ab449dd78bed923a49c7160e1886e987a3d", [:mix], [{:hackney, "~> 1.17", [hex: :hackney, repo: "hexpm", optional: false]}], "hexpm", "28089eaa98cf90c66265b6b5ad87c59a3729bea2e74e9d08f9b51eb9729b3c3a"}, "hut": {:hex, :hut, "1.3.0", "71f2f054e657c03f959cf1acc43f436ea87580696528ca2a55c8afb1b06c85e7", [:"erlang.mk", :rebar, :rebar3], [], "hexpm", "7e15d28555d8a1f2b5a3a931ec120af0753e4853a4c66053db354f35bf9ab563"}, "idna": {:hex, :idna, "6.1.1", "8a63070e9f7d0c62eb9d9fcb360a7de382448200fbbd1b106cc96d3d8099df8d", [:rebar3], [{:unicode_util_compat, "~>0.7.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm", "92376eb7894412ed19ac475e4a86f7b413c1b9fbb5bd16dccd57934157944cea"}, diff --git a/test/plausible_web/controllers/auth_controller_test.exs b/test/plausible_web/controllers/auth_controller_test.exs index 878f3f53d..b93ed8a19 100644 --- a/test/plausible_web/controllers/auth_controller_test.exs +++ b/test/plausible_web/controllers/auth_controller_test.exs @@ -203,6 +203,38 @@ defmodule PlausibleWeb.AuthControllerTest do assert get_session(conn, :current_user_id) == nil assert html_response(conn, 200) =~ "Enter your email and password" end + + test "limits login attempts to 5 per minute" do + user = insert(:user, password: "password") + + build_conn() + |> put_req_header("x-forwarded-for", "1.1.1.1") + |> post("/login", email: user.email, password: "wrong") + + build_conn() + |> put_req_header("x-forwarded-for", "1.1.1.1") + |> post("/login", email: user.email, password: "wrong") + + build_conn() + |> put_req_header("x-forwarded-for", "1.1.1.1") + |> post("/login", email: user.email, password: "wrong") + + build_conn() + |> put_req_header("x-forwarded-for", "1.1.1.1") + |> post("/login", email: user.email, password: "wrong") + + build_conn() + |> put_req_header("x-forwarded-for", "1.1.1.1") + |> post("/login", email: user.email, password: "wrong") + + conn = + build_conn() + |> put_req_header("x-forwarded-for", "1.1.1.1") + |> post("/login", email: user.email, password: "wrong") + + assert get_session(conn, :current_user_id) == nil + assert html_response(conn, 429) =~ "Too many login attempts" + end end describe "GET /password/request-reset" do