From 66b7d383d2b5e06a445144faa3645169f2892a48 Mon Sep 17 00:00:00 2001 From: Karl-Aksel Puulmann Date: Thu, 4 Apr 2024 12:28:09 +0300 Subject: [PATCH] Unify behavior of entry/exit page hostnames with rest --- lib/plausible/stats/breakdown.ex | 2 ++ lib/plausible/stats/filters/filters.ex | 4 +++- lib/plausible/stats/table_decider.ex | 2 ++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/plausible/stats/breakdown.ex b/lib/plausible/stats/breakdown.ex index 57711a174..693ccfae4 100644 --- a/lib/plausible/stats/breakdown.ex +++ b/lib/plausible/stats/breakdown.ex @@ -216,7 +216,9 @@ defmodule Plausible.Stats.Breakdown do # defp breakdown_table(%Query{experimental_reduced_joins?: false}, _, _), do: :session defp breakdown_table(_query, _metrics, "visit:entry_page"), do: :session + defp breakdown_table(_query, _metrics, "visit:entry_page_hostname"), do: :session defp breakdown_table(_query, _metrics, "visit:exit_page"), do: :session + defp breakdown_table(_query, _metrics, "visit:exit_page_hostname"), do: :session defp breakdown_table(query, metrics, property) do {_, session_metrics, _} = TableDecider.partition_metrics(metrics, query, property) diff --git a/lib/plausible/stats/filters/filters.ex b/lib/plausible/stats/filters/filters.ex index 1217b3141..732369686 100644 --- a/lib/plausible/stats/filters/filters.ex +++ b/lib/plausible/stats/filters/filters.ex @@ -32,7 +32,9 @@ defmodule Plausible.Stats.Filters do @event_table_visit_props @visit_props -- [ :entry_page, - :exit_page + :exit_page, + :entry_page_hostname, + :exit_page_hostname ] def event_table_visit_props(), do: @event_table_visit_props |> Enum.map(&to_string/1) diff --git a/lib/plausible/stats/table_decider.ex b/lib/plausible/stats/table_decider.ex index 436a25e16..ef976a060 100644 --- a/lib/plausible/stats/table_decider.ex +++ b/lib/plausible/stats/table_decider.ex @@ -85,7 +85,9 @@ defmodule Plausible.Stats.TableDecider do defp filters_partitioner(_, {"event:" <> _, _}), do: :event defp filters_partitioner(_, {"visit:entry_page", _}), do: :session + defp filters_partitioner(_, {"visit:entry_page_hostname", _}), do: :session defp filters_partitioner(_, {"visit:exit_page", _}), do: :session + defp filters_partitioner(_, {"visit:exit_page_hostname", _}), do: :session defp filters_partitioner(%Query{experimental_reduced_joins?: true}, {"visit:" <> _, _}), do: :either