Remove unused fields from pageviews

pull/15/head
Uku Taht 7 years ago
parent 815ce02136
commit 71edf2c86d

@ -5,15 +5,12 @@ defmodule Plausible.Pageview do
schema "pageviews" do
field :hostname, :string
field :pathname, :string
field :referrer, :string
field :raw_referrer, :string
field :user_agent, :string
field :screen_width, :integer
field :screen_size, :string
field :new_visitor, :boolean
field :user_id, :binary_id
field :country_code, :string
field :referrer, :string
field :screen_size, :string
field :country_code, :string
field :operating_system, :string
field :browser, :string
field :referrer_source, :string
@ -23,7 +20,7 @@ defmodule Plausible.Pageview do
def changeset(pageview, attrs) do
pageview
|> cast(attrs, [:hostname, :pathname, :referrer, :raw_referrer, :user_agent, :new_visitor, :screen_width, :user_id, :operating_system, :browser, :referrer_source, :country_code, :screen_size])
|> cast(attrs, [:hostname, :pathname, :referrer, :new_visitor, :user_id, :operating_system, :browser, :referrer_source, :country_code, :screen_size])
|> validate_required([:hostname, :pathname, :new_visitor, :user_id])
end
end

@ -45,14 +45,11 @@ defmodule PlausibleWeb.Api.ExternalController do
pageview_attrs = %{
hostname: strip_www(uri.host),
pathname: uri.path,
user_agent: user_agent,
new_visitor: params["new_visitor"],
screen_width: params["screen_width"],
country_code: country_code,
user_id: params["uid"],
operating_system: ua && os_name(ua),
browser: ua && browser_name(ua),
raw_referrer: params["referrer"],
referrer_source: ref && referrer_source(uri, ref),
referrer: ref && clean_referrer(params["referrer"]),
screen_size: calculate_screen_size(params["screen_width"])

@ -1,6 +1,5 @@
defmodule Plausible.Repo.Migrations.AddPublicSites do
use Ecto.Migration
alias Plausible.Repo
def change do
alter table(:sites) do

@ -1,7 +1,6 @@
defmodule Plausible.Repo.Migrations.AddEmailAddressToSettings do
use Ecto.Migration
use Plausible.Repo
alias Plausible.Site.EmailSettings
def change do
alter table(:email_settings) do
@ -9,12 +8,6 @@ defmodule Plausible.Repo.Migrations.AddEmailAddressToSettings do
end
flush()
all = Repo.all(EmailSettings)
for settings <- all do
mem = Repo.get_by(Plausible.Site.Membership, site_id: settings.site_id) |> Repo.preload(:user)
EmailSettings.changeset(settings, %{email: mem.user.email}) |> Repo.update!
end
alter table(:email_settings) do
modify :email, :citext, null: false

@ -0,0 +1,11 @@
defmodule Plausible.Repo.Migrations.RemoveUnusedFields do
use Ecto.Migration
def change do
alter table(:pageviews) do
remove :raw_referrer
remove :screen_width
remove :user_agent
end
end
end

@ -27,8 +27,6 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
assert pageview.hostname == "gigride.live"
assert pageview.pathname == "/"
assert pageview.new_visitor == true
assert pageview.user_agent == @user_agent
assert pageview.screen_width == params[:screen_width]
assert pageview.country_code == @country_code
end
@ -174,7 +172,6 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
pageview = Repo.one(Plausible.Pageview)
assert pageview.referrer == "indiehackers.com/page"
assert pageview.raw_referrer == "https://www.indiehackers.com/page?query=param#hash"
end
test "?ref= query param controls the referrer source", %{conn: conn} do

Loading…
Cancel
Save