From 7dec454a23f5d40a730858aafc19eb4e1d3b3e5d Mon Sep 17 00:00:00 2001 From: Adam Rutkowski Date: Thu, 23 Feb 2023 10:35:46 +0100 Subject: [PATCH] Don't rely on Mix.env check in runtime (#2703) --- lib/plausible_web/controllers/stats_controller.ex | 3 +-- test/test_helper.exs | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/plausible_web/controllers/stats_controller.ex b/lib/plausible_web/controllers/stats_controller.ex index 7607d75ba..e80bff9e3 100644 --- a/lib/plausible_web/controllers/stats_controller.ex +++ b/lib/plausible_web/controllers/stats_controller.ex @@ -96,8 +96,7 @@ defmodule PlausibleWeb.StatsController do query = Query.from(site, params) |> Filters.add_prefix() visits_metric_enabled = - FunWithFlags.enabled?(:visits_metric, for: conn.assigns[:current_user]) || - Mix.env() == :test + FunWithFlags.enabled?(:visits_metric, for: conn.assigns[:current_user]) metrics = if visits_metric_enabled && !query.filters["event:goal"] do diff --git a/test/test_helper.exs b/test/test_helper.exs index 85358b3df..62161c24a 100644 --- a/test/test_helper.exs +++ b/test/test_helper.exs @@ -1,6 +1,7 @@ {:ok, _} = Application.ensure_all_started(:ex_machina) Plausible.Test.ClickhouseSetup.run() Mox.defmock(Plausible.HTTPClient.Mock, for: Plausible.HTTPClient.Interface) +FunWithFlags.enable(:visits_metric) ExUnit.start(exclude: :slow) Application.ensure_all_started(:double) Ecto.Adapters.SQL.Sandbox.mode(Plausible.Repo, :manual)