Remove screen_width from ingestion completely

ua-device-type-ecto-query
Uku Taht 4 years ago
parent a0868b7e42
commit 8b6738e958

@ -90,7 +90,6 @@ defmodule Mix.Tasks.SendPageview do
url: "http://#{domain}#{page}",
domain: domain,
referrer: referrer,
width: 1666,
props: props
}
end

@ -16,7 +16,6 @@ defmodule Plausible.Ingestion.Request do
field :hostname, :string
field :referrer, :string
field :domains, {:array, :string}
field :screen_width, :string
field :hash_mode, :string
field :pathname, :string
field :props, :map
@ -89,7 +88,6 @@ defmodule Plausible.Ingestion.Request do
changeset,
event_name: request_body["n"] || request_body["name"],
referrer: request_body["r"] || request_body["referrer"],
screen_width: request_body["w"] || request_body["screen_width"],
hash_mode: request_body["h"] || request_body["hashMode"],
props: parse_props(request_body)
)

@ -142,7 +142,6 @@ defmodule Plausible.Ingestion.RequestTest do
domain: "dummy.site",
url: "http://dummy.site/index.html",
referrer: "https://example.com",
screen_width: 1024,
hashMode: 1,
props: %{
"custom1" => "property1",
@ -154,7 +153,6 @@ defmodule Plausible.Ingestion.RequestTest do
assert {:ok, request} = Request.build(conn)
assert request.referrer == "https://example.com"
assert request.screen_width == 1024
assert request.hash_mode == 1
assert request.props["custom1"] == "property1"
assert request.props["custom2"] == "property2"

@ -37,8 +37,7 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
params = %{
domain: domain,
name: "pageview",
url: "http://gigride.live/",
screen_width: 1440
url: "http://gigride.live/"
}
conn =
@ -489,7 +488,6 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
params = %{
name: "pageview",
url: "http://gigride.live/",
screen_width: nil,
domain: domain
}

@ -70,7 +70,6 @@
{{/if}}
payload.d = scriptEl.getAttribute('data-domain')
payload.r = document.referrer || null
payload.w = window.innerWidth
if (options && options.meta) {
payload.m = JSON.stringify(options.meta)
}

Loading…
Cancel
Save