diff --git a/test/plausible_web/controllers/api/internal_controller/sync_test.exs b/test/plausible_web/controllers/api/internal_controller/sync_test.exs new file mode 100644 index 000000000..6f32589af --- /dev/null +++ b/test/plausible_web/controllers/api/internal_controller/sync_test.exs @@ -0,0 +1,18 @@ +defmodule PlausibleWeb.Api.InternalController.SyncTest do + use PlausibleWeb.ConnCase, async: false + use Plausible.Repo + + describe "PUT /api/:domain/disable-feature" do + setup [:create_user, :log_in] + + test "when the logged-in user is an super-admin", %{conn: conn, user: user} do + site = insert(:site) + patch_env(:super_admin_user_ids, [user.id]) + + conn = put(conn, "/api/#{site.domain}/disable-feature", %{"feature" => "conversions"}) + + assert json_response(conn, 200) == "ok" + assert %{conversions_enabled: false} = Plausible.Sites.get_by_domain(site.domain) + end + end +end diff --git a/test/plausible_web/controllers/api/internal_controller_test.exs b/test/plausible_web/controllers/api/internal_controller_test.exs index 7b82657fd..76b28e4ee 100644 --- a/test/plausible_web/controllers/api/internal_controller_test.exs +++ b/test/plausible_web/controllers/api/internal_controller_test.exs @@ -100,16 +100,6 @@ defmodule PlausibleWeb.Api.InternalControllerTest do assert %{conversions_enabled: false} = Plausible.Sites.get_by_domain(site.domain) end - test "when the logged-in user is an super-admin", %{conn: conn, user: user} do - site = insert(:site) - patch_env(:super_admin_user_ids, [user.id]) - - conn = put(conn, "/api/#{site.domain}/disable-feature", %{"feature" => "conversions"}) - - assert json_response(conn, 200) == "ok" - assert %{conversions_enabled: false} = Plausible.Sites.get_by_domain(site.domain) - end - test "returns 401 when the logged-in user is a viewer of the site", %{conn: conn, user: user} do site = insert(:site) insert(:site_membership, user: user, site: site, role: :viewer) diff --git a/test/support/test_utils.ex b/test/support/test_utils.ex index 8de90e5c0..ceccde91d 100644 --- a/test/support/test_utils.ex +++ b/test/support/test_utils.ex @@ -11,6 +11,10 @@ defmodule Plausible.TestUtils do defmacro patch_env(env_key, value) do quote do + if __MODULE__.__info__(:attributes)[:ex_unit_async] == [true] do + raise "Patching env is unsafe in asynchronous tests. maybe extract the case elsewhere?" + end + original_env = Application.get_env(:plausible, unquote(env_key)) Application.put_env(:plausible, unquote(env_key), unquote(value))