Do not report hard bounce e-mail errors to Sentry (#2361)
parent
0fa6b688af
commit
9a61a10273
@ -1,29 +1,32 @@
|
||||
defmodule Plausible.Mailer do
|
||||
use Bamboo.Mailer, otp_app: :plausible
|
||||
|
||||
def send_email(email) do
|
||||
try do
|
||||
Plausible.Mailer.deliver_now!(email)
|
||||
rescue
|
||||
error ->
|
||||
Sentry.capture_exception(error,
|
||||
stacktrace: __STACKTRACE__,
|
||||
extra: %{extra: "Error while sending email"}
|
||||
)
|
||||
|
||||
reraise error, __STACKTRACE__
|
||||
@spec send(Bamboo.Email.t()) :: :ok | {:error, :hard_bounce} | {:error, :unknown_error}
|
||||
def send(email) do
|
||||
case deliver_now(email) do
|
||||
{:ok, _email} -> :ok
|
||||
{:ok, _email, _response} -> :ok
|
||||
{:error, error} -> handle_error(error)
|
||||
end
|
||||
end
|
||||
|
||||
def send_email_safe(email) do
|
||||
try do
|
||||
Plausible.Mailer.deliver_now!(email)
|
||||
rescue
|
||||
error ->
|
||||
Sentry.capture_exception(error,
|
||||
stacktrace: __STACKTRACE__,
|
||||
extra: %{extra: "Error while sending email"}
|
||||
)
|
||||
defp handle_error(%{response: response}) when is_binary(response) do
|
||||
case Jason.decode(response) do
|
||||
{:ok, %{"ErrorCode" => 406}} ->
|
||||
{:error, :hard_bounce}
|
||||
|
||||
{:ok, response} ->
|
||||
Sentry.capture_message("Failed to send e-mail", extra: %{response: response})
|
||||
{:error, :unknown_error}
|
||||
|
||||
{:error, _any} ->
|
||||
Sentry.capture_message("Failed to send e-mail", extra: %{response: response})
|
||||
{:error, :unknown_error}
|
||||
end
|
||||
end
|
||||
|
||||
defp handle_error(error) do
|
||||
Sentry.capture_message("Failed to send e-mail", extra: %{response: error})
|
||||
{:error, :unknown_error}
|
||||
end
|
||||
end
|
||||
|
||||
@ -0,0 +1,12 @@
|
||||
defmodule Plausible.MailerTest do
|
||||
use Plausible.DataCase
|
||||
use Bamboo.Test
|
||||
|
||||
test "send/1 sends an email" do
|
||||
user = build(:user)
|
||||
email = PlausibleWeb.Email.welcome_email(user)
|
||||
|
||||
assert :ok == Plausible.Mailer.send(email)
|
||||
assert_delivered_email(email)
|
||||
end
|
||||
end
|
||||
Loading…
Reference in New Issue