Get rid of the funnels flag completely (#3341)

pull/3343/head r2023.09.13-190
hq1 3 years ago committed by GitHub
parent 43be271836
commit a9bfaed70f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -24,7 +24,7 @@ export const sectionTitles = {
}
export default function Behaviours(props) {
const {site, query, currentUserRole} = props
const { site, query, currentUserRole } = props
const adminAccess = ['owner', 'admin', 'super_admin'].includes(currentUserRole)
const tabKey = `behavioursTab__${site.domain}`
const funnelKey = `behavioursTabFunnel__${site.domain}`
@ -243,7 +243,7 @@ export default function Behaviours(props) {
if (site.propsEnabled) {
enabledModes.push(PROPS)
}
if (site.funnelsEnabled && !isRealtime() && site.flags.funnels) {
if (site.funnelsEnabled && !isRealtime()) {
enabledModes.push(FUNNELS)
}
return enabledModes

@ -13,11 +13,6 @@ defmodule Plausible.Funnels do
import Ecto.Query
@spec enabled_for?(any()) :: boolean()
def enabled_for?(actor) do
FunWithFlags.enabled?(:funnels, for: actor)
end
@spec create(Plausible.Site.t(), String.t(), [map()]) ::
{:ok, Funnel.t()}
| {:error, Ecto.Changeset.t() | :invalid_funnel_size}

@ -1,6 +1,5 @@
{:ok, _} = Application.ensure_all_started(:ex_machina)
Mox.defmock(Plausible.HTTPClient.Mock, for: Plausible.HTTPClient.Interface)
Application.ensure_all_started(:double)
FunWithFlags.enable(:funnels)
Ecto.Adapters.SQL.Sandbox.mode(Plausible.Repo, :manual)
ExUnit.configure(exclude: [:slow])

Loading…
Cancel
Save