Test getting conversions with a goal filter

pull/18/head
Uku Taht 7 years ago
parent f71f98a521
commit b5797c8b10

@ -205,10 +205,10 @@ defmodule Plausible.Stats do
def goal_conversions(site, %Query{filters: %{"goal" => goal}} = query) when is_binary(goal) do
Repo.all(from e in base_query(site, query),
select: %{name: ^goal, count: count(e.user_id, :distinct)},
select: count(e.user_id, :distinct),
group_by: e.name,
order_by: [desc: 2]
)
order_by: [desc: 1]
) |> Enum.map(fn count -> %{name: goal, count: count} end)
end
def goal_conversions(site, query) do

@ -54,4 +54,23 @@ defmodule PlausibleWeb.Api.StatsController.ConversionsTest do
]
end
end
describe "GET /api/stats/:domain/conversions - with goal filter" do
setup [:create_user, :log_in, :create_site]
test "returns only the conversion tha is filtered for", %{conn: conn, site: site} do
insert(:goal, %{domain: site.domain, page_path: "/success"})
insert(:goal, %{domain: site.domain, event_name: "Signup"})
insert(:event, name: "Signup", hostname: site.domain, timestamp: ~N[2019-01-01 01:00:00])
insert(:event, name: "pageview", pathname: "/success", hostname: site.domain, timestamp: ~N[2019-01-01 01:00:00])
filters = Jason.encode!(%{goal: "Signup"})
conn = get(conn, "/api/stats/#{site.domain}/conversions?period=day&date=2019-01-01&filters=#{filters}")
assert json_response(conn, 200) == [
%{"name" => "Signup", "count" => 1},
]
end
end
end

Loading…
Cancel
Save