From b6d30019efe308badd8cdf21d94f8517dbc3e170 Mon Sep 17 00:00:00 2001 From: Vini Brasil Date: Mon, 2 Jan 2023 11:46:18 -0300 Subject: [PATCH] Cascade delete sent_renewal_notifications table when user is deleted (#2549) * Cascade delete sent_renewal_notifications table when user is deleted This commit fixes a bug when deleting a user would trigger a constraint error. * Update CHANGELOG.md --- CHANGELOG.md | 3 +++ ...3226_cascade_delete_sent_renewal_notifications.exs | 11 +++++++++++ .../controllers/auth_controller_test.exs | 7 +++++++ 3 files changed, 21 insertions(+) create mode 100644 priv/repo/migrations/20221228123226_cascade_delete_sent_renewal_notifications.exs diff --git a/CHANGELOG.md b/CHANGELOG.md index 528a10bde..6f1680669 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,9 @@ All notable changes to this project will be documented in this file. - Reject events with long URIs and data URIs plausible/analytics#2536 - Always show direct traffic in sources reports plausible/analytics#2531 +## Fixed +- Cascade delete sent_renewal_notifications table when user is deleted plausible/analytics#2549 + ## v1.5.1 - 2022-12-06 ### Fixed diff --git a/priv/repo/migrations/20221228123226_cascade_delete_sent_renewal_notifications.exs b/priv/repo/migrations/20221228123226_cascade_delete_sent_renewal_notifications.exs new file mode 100644 index 000000000..15d484634 --- /dev/null +++ b/priv/repo/migrations/20221228123226_cascade_delete_sent_renewal_notifications.exs @@ -0,0 +1,11 @@ +defmodule Plausible.Repo.Migrations.CascadeDeleteSentRenewalNotifications do + use Ecto.Migration + + def change do + drop constraint("sent_renewal_notifications", "sent_renewal_notifications_user_id_fkey") + + alter table(:sent_renewal_notifications) do + modify :user_id, references(:users, on_delete: :delete_all), null: false + end + end +end diff --git a/test/plausible_web/controllers/auth_controller_test.exs b/test/plausible_web/controllers/auth_controller_test.exs index 7da7c544f..fd2211ece 100644 --- a/test/plausible_web/controllers/auth_controller_test.exs +++ b/test/plausible_web/controllers/auth_controller_test.exs @@ -677,6 +677,13 @@ defmodule PlausibleWeb.AuthControllerTest do } ]) + Repo.insert_all("sent_renewal_notifications", [ + %{ + user_id: user.id, + timestamp: NaiveDateTime.utc_now() + } + ]) + insert(:google_auth, site: site, user: user) insert(:subscription, user: user, status: "deleted")