From ba36b08fd61111f939f1de61872c3eb51df61a46 Mon Sep 17 00:00:00 2001 From: Vinicius Brasil Date: Thu, 21 Jul 2022 08:00:42 -0300 Subject: [PATCH] Make realtime goal conversions clickable (#2035) Closes #1739 --- CHANGELOG.md | 1 + assets/js/dashboard/stats/conversions/index.js | 16 +--------------- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fa9c9c63d..b07c06749 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,7 @@ All notable changes to this project will be documented in this file. - Add ability to import historical data from GA: plausible/analytics#1753 - API route `GET /api/v1/sites/:site_id` - Hovering on top of list items will now show a [tooltip with the exact number instead of a shortened version](https://github.com/plausible/analytics/discussions/1968) +- Filter goals in realtime filter by clicking goal name ### Fixed - UI fix where multi-line text in pills would not be underlined properly on small screens. diff --git a/assets/js/dashboard/stats/conversions/index.js b/assets/js/dashboard/stats/conversions/index.js index e63ac2ee8..caf65876f 100644 --- a/assets/js/dashboard/stats/conversions/index.js +++ b/assets/js/dashboard/stats/conversions/index.js @@ -59,20 +59,6 @@ export default class Conversions extends React.Component { .then((res) => this.setState({loading: false, goals: res, prevHeight: null})) } - renderGoalText(goalName) { - if (this.props.query.period === 'realtime') { - return {goalName} - } else { - return ( - - {goalName} - - ) - } - } - - - renderGoal(goal) { const { viewport } = this.state; const renderProps = this.props.query.filters['goal'] == goal.name && goal.prop_names @@ -87,7 +73,7 @@ export default class Conversions extends React.Component { maxWidthDeduction={this.getBarMaxWidth()} plot="unique_conversions" > - {this.renderGoalText(goal.name)} + {goal.name}
{numberFormatter(goal.unique_conversions)}