Make event filter handling more consistent

External stats controller didn't handle event:page filters.
Query#remove_event_filters didn't handle event:name filter removal
consistency-api
Karl-Aksel Puulmann 3 years ago
parent c5881cdc6d
commit bcb45a4498

@ -194,6 +194,7 @@ defmodule Plausible.Stats.Query do
new_filters =
Enum.filter(query.filters, fn {filter_key, _} ->
cond do
:name in opts && filter_key == "event:name" -> false
:page in opts && filter_key == "event:page" -> false
:goal in opts && filter_key == "event:goal" -> false
:props in opts && filter_key && String.starts_with?(filter_key, "event:props:") -> false

@ -234,6 +234,7 @@ defmodule PlausibleWeb.Api.ExternalStatsController do
end
defp event_only_property?("event:name"), do: true
defp event_only_property?("event:page"), do: true
defp event_only_property?("event:goal"), do: true
defp event_only_property?("event:props:" <> _), do: true
defp event_only_property?(_), do: false

Loading…
Cancel
Save