Extract funnel settings test module

pull/2859/head
Adam Rutkowski 4 years ago
parent da474a47a1
commit c0dea3f354

@ -38,7 +38,7 @@ defmodule PlausibleWeb.Live.FunnelSettings do
funnels={@funnels}
site={@site}
/>
<button type="button" class="button mt-6" phx-click="add_funnel">+ Add funnel</button>
<button type="button" class="button mt-6" phx-click="add-funnel">+ Add funnel</button>
</div>
<div :if={Enum.count(@goals) < 2}>
<div class="rounded-md bg-yellow-100 p-4 mt-8">
@ -55,11 +55,11 @@ defmodule PlausibleWeb.Live.FunnelSettings do
"""
end
def handle_event("add_funnel", _value, socket) do
def handle_event("add-funnel", _value, socket) do
{:noreply, assign(socket, add_funnel?: true)}
end
def handle_event("cancel_add_funnel", _value, socket) do
def handle_event("cancel-add-funnel", _value, socket) do
{:noreply, assign(socket, add_funnel?: false)}
end

@ -168,7 +168,7 @@ defmodule PlausibleWeb.Live.FunnelSettings.Form do
<button
type="button"
class="inline-block mt-4 ml-2 px-4 py-2 border border-gray-300 dark:border-gray-500 text-sm leading-5 font-medium rounded-md text-red-700 bg-white dark:bg-gray-800 hover:text-red-500 dark:hover:text-red-400 focus:outline-none focus:border-blue-300 focus:ring active:text-red-800 active:bg-gray-50 transition ease-in-out duration-150 "
phx-click="cancel_add_funnel"
phx-click="cancel-add-funnel"
>
Cancel
</button>

@ -0,0 +1,48 @@
defmodule PlausibleWeb.FunnelSettingsTest do
use PlausibleWeb.ConnCase, async: false
describe "GET /:website/settings/funnels" do
setup [:create_user, :log_in, :create_site]
test "lists funnels for the site and renders help link", %{conn: conn, site: site} do
:ok = setup_funnels(site)
conn = get(conn, "/#{site.domain}/settings/funnels")
resp = html_response(conn, 200)
assert resp =~ "Compose goals into funnels"
assert resp =~ "From blog to signup"
assert resp =~ "From signup to blog"
doc = Floki.parse_document!(resp)
assert [{"a", _, _}] = Floki.find(doc, "a[href=\"https://plausible.io/docs/funnels\"]")
end
test "if goals are present, Add Funnel button is rendered", %{conn: conn, site: site} do
:ok = setup_funnels(site)
conn = get(conn, "/#{site.domain}/settings/funnels")
doc = conn |> html_response(200) |> Floki.parse_document!()
assert [_] = Floki.find(doc, ~S/button[phx-click="add-funnel"]/)
end
end
defp setup_funnels(site) do
{:ok, g1} = Plausible.Goals.create(site, %{"page_path" => "/go/to/blog/**"})
{:ok, g2} = Plausible.Goals.create(site, %{"event_name" => "Signup"})
{:ok, _} =
Plausible.Funnels.create(
site,
"From blog to signup",
[%{"goal_id" => g1.id}, %{"goal_id" => g2.id}]
)
{:ok, _} =
Plausible.Funnels.create(
site,
"From signup to blog",
[%{"goal_id" => g2.id}, %{"goal_id" => g1.id}]
)
:ok
end
end

@ -1329,37 +1329,4 @@ defmodule PlausibleWeb.SiteControllerTest do
"Your domain has been changed. You must update the JavaScript snippet on your site within 72 hours"
end
end
describe "GET /:website/settings/funnels" do
setup [:create_user, :log_in, :create_site]
test "lists funnels for the site and renders help link", %{conn: conn, site: site} do
{:ok, g1} = Plausible.Goals.create(site, %{"page_path" => "/go/to/blog/**"})
{:ok, g2} = Plausible.Goals.create(site, %{"event_name" => "Signup"})
{:ok, _} =
Plausible.Funnels.create(
site,
"From blog to signup",
[%{"goal_id" => g1.id}, %{"goal_id" => g2.id}]
)
{:ok, _} =
Plausible.Funnels.create(
site,
"From signup to blog",
[%{"goal_id" => g2.id}, %{"goal_id" => g1.id}]
)
conn = get(conn, "/#{site.domain}/settings/funnels")
resp = html_response(conn, 200)
assert resp =~ "Compose goals into funnels"
assert resp =~ "From blog to signup"
assert resp =~ "From signup to blog"
doc = Floki.parse_document!(resp)
assert [{"a", _, _}] = Floki.find(doc, "a[href=\"https://plausible.io/docs/funnels\"]")
end
end
end

Loading…
Cancel
Save