diff --git a/test/plausible_web/controllers/api/external_controller_test.exs b/test/plausible_web/controllers/api/external_controller_test.exs index a3f081d8e..204c2ef2b 100644 --- a/test/plausible_web/controllers/api/external_controller_test.exs +++ b/test/plausible_web/controllers/api/external_controller_test.exs @@ -398,24 +398,45 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do assert pageview["country_code"] == "US" end - test "URL and source are decoded", %{conn: conn} do - params = %{ - name: "pageview", - url: "http://www.example.com/opportunity/category/%D8%AC%D9%88%D8%A7%D8%A6%D8%B2-%D9%88%D9%85%D8%B3%D8%A7%D8%A8%D9%82%D8%A7%D8%AA", - source: "Hello%20World", - domain: "external-controller-test-21.com" - } + test "URL and source are decoded", %{conn: conn} do + params = %{ + name: "pageview", + url: "http://www.example.com/opportunity/category/%D8%AC%D9%88%D8%A7%D8%A6%D8%B2-%D9%88%D9%85%D8%B3%D8%A7%D8%A8%D9%82%D8%A7%D8%AA", + source: "Hello%20World", + domain: "external-controller-test-21.com" + } - conn - |> put_req_header("content-type", "text/plain") - |> post("/api/event", Jason.encode!(params)) + conn + |> put_req_header("content-type", "text/plain") + |> post("/api/event", Jason.encode!(params)) - pageview = get_event("external-controller-test-21.com") + pageview = get_event("external-controller-test-21.com") - assert pageview["pathname"] == "/opportunity/category/جوائز-ومسابقات" - assert pageview["referrer_source"] == "Hello World" - end + assert pageview["pathname"] == "/opportunity/category/جوائز-ومسابقات" + assert pageview["referrer_source"] == "Hello World" + end + + test "accepts shorthand map keys", %{conn: conn} do + params = %{ + n: "pageview", + u: "http://www.example.com/opportunity", + s: "Hello%20World", + d: "external-controller-test-22.com", + r: "https://facebook.com/page", + w: 300 + } + + conn + |> put_req_header("content-type", "text/plain") + |> post("/api/event", Jason.encode!(params)) + pageview = get_event("external-controller-test-22.com") + + assert pageview["pathname"] == "/opportunity" + assert pageview["referrer_source"] == "Hello World" + assert pageview["referrer"] == "facebook.com/page" + assert pageview["screen_size"] == "Mobile" + end test "responds 400 when required fields are missing", %{conn: conn} do params = %{}