From c913d2fbb9bad23844e1ada546449187919d8b72 Mon Sep 17 00:00:00 2001 From: Uku Taht Date: Tue, 21 Sep 2021 10:53:21 +0200 Subject: [PATCH] Fix referrer drilldown for Google Fixes #1341 --- lib/plausible_web/controllers/api/stats_controller.ex | 6 +++++- .../controllers/api/stats_controller/sources_test.exs | 4 ++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/plausible_web/controllers/api/stats_controller.ex b/lib/plausible_web/controllers/api/stats_controller.ex index e8e3a50d5..e8d096042 100644 --- a/lib/plausible_web/controllers/api/stats_controller.ex +++ b/lib/plausible_web/controllers/api/stats_controller.ex @@ -278,7 +278,11 @@ defmodule PlausibleWeb.Api.StatsController do def referrer_drilldown(conn, %{"referrer" => "Google"} = params) do site = conn.assigns[:site] |> Repo.preload(:google_auth) - query = Query.from(site.timezone, params) + + query = + Query.from(site.timezone, params) + |> Query.put_filter("source", "Google") + |> Filters.add_prefix() search_terms = if site.google_auth && site.google_auth.property && !query.filters["goal"] do diff --git a/test/plausible_web/controllers/api/stats_controller/sources_test.exs b/test/plausible_web/controllers/api/stats_controller/sources_test.exs index 049420872..ab82603f9 100644 --- a/test/plausible_web/controllers/api/stats_controller/sources_test.exs +++ b/test/plausible_web/controllers/api/stats_controller/sources_test.exs @@ -433,6 +433,10 @@ defmodule PlausibleWeb.Api.StatsController.SourcesTest do insert(:google_auth, user: user, user: user, site: site, property: "sc-domain:example.com") populate_stats(site, [ + build(:pageview, + referrer_source: "DuckDuckGo", + referrer: "duckduckgo.com" + ), build(:pageview, referrer_source: "Google", referrer: "google.com"