From d1fe184cb752cf971d212d36e0dc174a9e23a33b Mon Sep 17 00:00:00 2001 From: Karl-Aksel Puulmann Date: Tue, 13 Feb 2024 08:28:23 +0200 Subject: [PATCH] Remove ORDER BY min(session.start) (#3771) This adds a needless performance overhead. Note that all queries already sort by the _name_ of the breakdown value besides the session start. --- lib/plausible/stats/breakdown.ex | 2 +- test/plausible_web/controllers/CSVs/30d/browser_versions.csv | 2 +- test/plausible_web/controllers/CSVs/30d/browsers.csv | 2 +- test/plausible_web/controllers/CSVs/6m/browser_versions.csv | 2 +- test/plausible_web/controllers/CSVs/6m/browsers.csv | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/plausible/stats/breakdown.ex b/lib/plausible/stats/breakdown.ex index a9b8e4d68..6586d6cfd 100644 --- a/lib/plausible/stats/breakdown.ex +++ b/lib/plausible/stats/breakdown.ex @@ -201,7 +201,7 @@ defmodule Plausible.Stats.Breakdown do defp breakdown_sessions(site, query, property, metrics, pagination) do from(s in query_sessions(site, query), - order_by: [desc: fragment("uniq(?)", s.user_id), asc: fragment("min(?)", s.start)], + order_by: [desc: fragment("uniq(?)", s.user_id)], select: %{} ) |> filter_converted_sessions(site, query) diff --git a/test/plausible_web/controllers/CSVs/30d/browser_versions.csv b/test/plausible_web/controllers/CSVs/30d/browser_versions.csv index 6ea976358..c31f80f7e 100644 --- a/test/plausible_web/controllers/CSVs/30d/browser_versions.csv +++ b/test/plausible_web/controllers/CSVs/30d/browser_versions.csv @@ -1,3 +1,3 @@ name,version,visitors -Firefox,120,2 (not set),(not set),2 +Firefox,120,2 diff --git a/test/plausible_web/controllers/CSVs/30d/browsers.csv b/test/plausible_web/controllers/CSVs/30d/browsers.csv index 7c43ba903..21acd82ed 100644 --- a/test/plausible_web/controllers/CSVs/30d/browsers.csv +++ b/test/plausible_web/controllers/CSVs/30d/browsers.csv @@ -1,3 +1,3 @@ name,visitors -Firefox,2 (not set),2 +Firefox,2 diff --git a/test/plausible_web/controllers/CSVs/6m/browser_versions.csv b/test/plausible_web/controllers/CSVs/6m/browser_versions.csv index ec5d54b4c..2d11b2d3e 100644 --- a/test/plausible_web/controllers/CSVs/6m/browser_versions.csv +++ b/test/plausible_web/controllers/CSVs/6m/browser_versions.csv @@ -1,4 +1,4 @@ name,version,visitors -Firefox,120,2 (not set),(not set),2 +Firefox,120,2 FirefoxNoVersion,(not set),1 diff --git a/test/plausible_web/controllers/CSVs/6m/browsers.csv b/test/plausible_web/controllers/CSVs/6m/browsers.csv index eba98919d..1fb598123 100644 --- a/test/plausible_web/controllers/CSVs/6m/browsers.csv +++ b/test/plausible_web/controllers/CSVs/6m/browsers.csv @@ -1,4 +1,4 @@ name,visitors -Firefox,2 (not set),2 +Firefox,2 FirefoxNoVersion,1