From d9e9e04bdaa286b91a2aeb7026963c784cd091b3 Mon Sep 17 00:00:00 2001 From: Adam Rutkowski Date: Thu, 26 Oct 2023 12:45:46 +0200 Subject: [PATCH] Test `last_24h_visitors_hourly_intervals/2` --- test/plausible/stats/clickhouse_test.exs | 138 +++++++++++++++++++++++ test/support/test_utils.ex | 8 +- 2 files changed, 139 insertions(+), 7 deletions(-) create mode 100644 test/plausible/stats/clickhouse_test.exs diff --git a/test/plausible/stats/clickhouse_test.exs b/test/plausible/stats/clickhouse_test.exs new file mode 100644 index 000000000..d91058f6f --- /dev/null +++ b/test/plausible/stats/clickhouse_test.exs @@ -0,0 +1,138 @@ +defmodule Plausible.Stats.ClickhouseTest do + use Plausible.DataCase, async: true + import Plausible.TestUtils + alias Plausible.Stats.Clickhouse + + describe "last_24_visitors_hourly_intervals/1" do + test "returns no data on no sites" do + assert Clickhouse.last_24h_visitors_hourly_intervals([]) == %{} + end + + test "returns empty intervals placeholder on no clickhouse stats" do + fixed_now = ~N[2023-10-26 10:00:15] + site = insert(:site) + domain = site.domain + + assert Clickhouse.last_24h_visitors_hourly_intervals( + [site], + fixed_now + ) == + %{ + domain => %{ + visitors: 0, + intervals: [ + %{interval: ~N[2023-10-25 11:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 12:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 13:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 14:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 15:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 16:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 17:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 18:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 19:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 20:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 21:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 22:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 23:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 00:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 01:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 02:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 03:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 04:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 05:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 06:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 07:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 08:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 09:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 10:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 11:00:00], visitors: 0} + ] + } + } + end + + test "returns clickhouse data merged with placeholder" do + fixed_now = ~N[2023-10-26 10:00:15] + site = insert(:site) + + user_id = 111 + + populate_stats(site, [ + build(:pageview, timestamp: ~N[2023-10-25 13:59:00]), + build(:pageview, timestamp: ~N[2023-10-25 13:58:00]), + build(:pageview, user_id: user_id, timestamp: ~N[2023-10-25 15:00:00]), + build(:pageview, user_id: user_id, timestamp: ~N[2023-10-25 15:01:00]) + ]) + + %{ + visitors: 3, + intervals: [ + %{interval: ~N[2023-10-25 11:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 12:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 13:00:00], visitors: 2}, + %{interval: ~N[2023-10-25 14:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 15:00:00], visitors: 1}, + %{interval: ~N[2023-10-25 16:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 17:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 18:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 19:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 20:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 21:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 22:00:00], visitors: 0}, + %{interval: ~N[2023-10-25 23:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 00:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 01:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 02:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 03:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 04:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 05:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 06:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 07:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 08:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 09:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 10:00:00], visitors: 0}, + %{interval: ~N[2023-10-26 11:00:00], visitors: 0} + ] + } = Clickhouse.last_24h_visitors_hourly_intervals([site], fixed_now)[site.domain] + end + + test "returns clickhouse data merged with placeholder for multiple sites" do + fixed_now = ~N[2023-10-26 10:00:15] + site1 = insert(:site) + site2 = insert(:site) + site3 = insert(:site) + + user_id = 111 + + populate_stats(site1, [ + build(:pageview, user_id: user_id, timestamp: ~N[2023-10-25 13:00:00]), + build(:pageview, user_id: user_id, timestamp: ~N[2023-10-25 13:01:00]), + build(:pageview, timestamp: ~N[2023-10-25 15:59:00]), + build(:pageview, timestamp: ~N[2023-10-25 15:58:00]) + ]) + + populate_stats(site2, [ + build(:pageview, timestamp: ~N[2023-10-25 13:59:00]), + build(:pageview, timestamp: ~N[2023-10-25 13:58:00]), + build(:pageview, user_id: user_id, timestamp: ~N[2023-10-25 15:00:00]), + build(:pageview, user_id: user_id, timestamp: ~N[2023-10-25 15:01:00]) + ]) + + assert result = + Clickhouse.last_24h_visitors_hourly_intervals([site1, site2, site3], fixed_now) + + assert result[site1.domain].visitors == 3 + assert result[site2.domain].visitors == 3 + assert result[site3.domain].visitors == 0 + + find_interval = fn result, domain, interval -> + Enum.find(result[domain].intervals, &(&1.interval == interval)) + end + + assert find_interval.(result, site1.domain, ~N[2023-10-25 13:00:00]).visitors == 1 + assert find_interval.(result, site1.domain, ~N[2023-10-25 15:00:00]).visitors == 2 + assert find_interval.(result, site2.domain, ~N[2023-10-25 13:00:00]).visitors == 2 + assert find_interval.(result, site2.domain, ~N[2023-10-25 15:00:00]).visitors == 1 + end + end +end diff --git a/test/support/test_utils.ex b/test/support/test_utils.ex index b64e9847d..b0987a860 100644 --- a/test/support/test_utils.ex +++ b/test/support/test_utils.ex @@ -147,13 +147,7 @@ defmodule Plausible.TestUtils do def populate_stats(site, events) do Enum.map(events, fn event -> - case event do - %Plausible.ClickhouseEventV2{} -> - Map.put(event, :site_id, site.id) - - _ -> - Map.put(event, :site_id, site.id) - end + Map.put(event, :site_id, site.id) end) |> populate_stats end