diff --git a/lib/plausible_web/controllers/api/stats_controller.ex b/lib/plausible_web/controllers/api/stats_controller.ex index e984da9f2..edd9b29d3 100644 --- a/lib/plausible_web/controllers/api/stats_controller.ex +++ b/lib/plausible_web/controllers/api/stats_controller.ex @@ -46,15 +46,11 @@ defmodule PlausibleWeb.Api.StatsController do bounce_rate = Stats.bounce_rate(site, query) prev_bounce_rate = Stats.bounce_rate(site, prev_query) change_bounce_rate = if prev_bounce_rate > 0, do: bounce_rate - prev_bounce_rate - session_length = Stats.session_length(site, query) - prev_session_length = Stats.session_length(site, prev_query) - change_session_length = if prev_session_length > 0, do: session_length - prev_session_length [ %{name: "Unique visitors", count: visitors, change: percent_change(prev_visitors, visitors)}, %{name: "Total pageviews", count: pageviews, change: percent_change(prev_pageviews, pageviews)}, %{name: "Bounce rate", percentage: bounce_rate, change: change_bounce_rate}, - %{name: "Session length", duration: session_length, change: change_session_length}, ] end diff --git a/test/plausible_web/controllers/api/stats_controller/main_graph_test.exs b/test/plausible_web/controllers/api/stats_controller/main_graph_test.exs index 546b1ba9a..b4311253a 100644 --- a/test/plausible_web/controllers/api/stats_controller/main_graph_test.exs +++ b/test/plausible_web/controllers/api/stats_controller/main_graph_test.exs @@ -152,28 +152,6 @@ defmodule PlausibleWeb.Api.StatsController.MainGraphTest do res = json_response(conn, 200) assert %{"name" => "Bounce rate", "percentage" => 67, "change" => 17} in res["top_stats"] end - - test "calculates avg session length", %{conn: conn, site: site} do - insert(:session, hostname: site.domain, length: 10, start: ~N[2019-01-01 01:00:00]) - insert(:session, hostname: site.domain, length: 20, start: ~N[2019-01-01 02:00:00]) - - conn = get(conn, "/api/stats/#{site.domain}/main-graph?period=day&date=2019-01-01") - - res = json_response(conn, 200) - assert %{"name" => "Session length", "duration" => 15, "change" => nil} in res["top_stats"] - end - - test "calculates change in session length", %{conn: conn, site: site} do - insert(:session, hostname: site.domain, length: 10, start: ~N[2019-01-01 01:00:00]) - insert(:session, hostname: site.domain, length: 20, start: ~N[2019-01-01 02:00:00]) - - insert(:session, hostname: site.domain, length: 20, start: ~N[2019-01-02 02:00:00]) - - conn = get(conn, "/api/stats/#{site.domain}/main-graph?period=day&date=2019-01-02") - - res = json_response(conn, 200) - assert %{"name" => "Session length", "duration" => 20, "change" => 5} in res["top_stats"] - end end