From e12b9fa42c1e31fe8b8de35e2d70e8da50b412d8 Mon Sep 17 00:00:00 2001 From: Uku Taht Date: Wed, 31 Mar 2021 16:48:56 +0300 Subject: [PATCH] Use GET instead of POST for logout Fixes #730 --- lib/plausible_web/router.ex | 2 +- lib/plausible_web/templates/layout/_header.html.eex | 2 +- test/plausible_web/controllers/admin_auth_controller_test.exs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/plausible_web/router.ex b/lib/plausible_web/router.ex index 2ec1d8a86..78cb52664 100644 --- a/lib/plausible_web/router.ex +++ b/lib/plausible_web/router.ex @@ -122,7 +122,7 @@ defmodule PlausibleWeb.Router do get "/password", AuthController, :password_form post "/password", AuthController, :set_password - post "/logout", AuthController, :logout + get "/logout", AuthController, :logout get "/settings", AuthController, :user_settings put "/settings", AuthController, :save_settings delete "/me", AuthController, :delete_me diff --git a/lib/plausible_web/templates/layout/_header.html.eex b/lib/plausible_web/templates/layout/_header.html.eex index bada40a72..9c2c42c30 100644 --- a/lib/plausible_web/templates/layout/_header.html.eex +++ b/lib/plausible_web/templates/layout/_header.html.eex @@ -39,7 +39,7 @@ diff --git a/test/plausible_web/controllers/admin_auth_controller_test.exs b/test/plausible_web/controllers/admin_auth_controller_test.exs index c3056342f..282dac10b 100644 --- a/test/plausible_web/controllers/admin_auth_controller_test.exs +++ b/test/plausible_web/controllers/admin_auth_controller_test.exs @@ -23,7 +23,7 @@ defmodule PlausibleWeb.AdminAuthControllerTest do assert redirected_to(conn) == "/sites" # trying logging out - conn = post(conn, "/logout") + conn = get(conn, "/logout") assert redirected_to(conn) == "/" conn = get(conn, "/") assert redirected_to(conn) == "/sites"