Fix tests
parent
9b9160ae86
commit
e14001664c
@ -1,76 +0,0 @@
|
||||
defmodule Plausible.Ingest.Session do
|
||||
use GenServer
|
||||
use Plausible.Repo
|
||||
|
||||
@session_timeout Application.get_env(:plausible, :session_timeout)
|
||||
|
||||
def on_event(event) do
|
||||
user_session = :global.whereis_name(event.user_id)
|
||||
|
||||
if is_pid(user_session) do
|
||||
GenServer.cast(user_session, {:on_event, event})
|
||||
else
|
||||
GenServer.start_link(__MODULE__, event, name: {:global, event.user_id})
|
||||
end
|
||||
end
|
||||
|
||||
def on_unload(user_id, timestamp) do
|
||||
user_session = :global.whereis_name(user_id)
|
||||
|
||||
if is_pid(user_session) do
|
||||
GenServer.cast(user_session, {:on_unload, timestamp})
|
||||
end
|
||||
end
|
||||
|
||||
def init(event) do
|
||||
timer = Process.send_after(self(), :finalize, @session_timeout)
|
||||
{:ok, %{first_event: event, last_event: event, timer: timer, is_bounce: true, last_unload: nil}}
|
||||
end
|
||||
|
||||
def handle_cast({:on_event, event}, state) do
|
||||
Process.cancel_timer(state[:timer])
|
||||
new_timer = Process.send_after(self(), :finalize, @session_timeout)
|
||||
{:noreply, %{state | timer: new_timer, last_event: event, is_bounce: false, last_unload: nil}}
|
||||
end
|
||||
|
||||
def handle_cast({:on_unload, timestamp}, state) do
|
||||
{:noreply, %{state | last_unload: timestamp}}
|
||||
end
|
||||
|
||||
def handle_info(:finalize, state) do
|
||||
first_event = state[:first_event]
|
||||
last_event = state[:last_event]
|
||||
|
||||
if !is_potential_leftover?(first_event) do
|
||||
length = if state[:last_unload] do
|
||||
Timex.diff(state[:last_unload], first_event.timestamp, :seconds)
|
||||
end
|
||||
|
||||
Plausible.Session.changeset(%Plausible.Session{}, %{
|
||||
hostname: first_event.hostname,
|
||||
domain: first_event.domain,
|
||||
user_id: first_event.user_id,
|
||||
new_visitor: first_event.new_visitor,
|
||||
entry_page: first_event.pathname,
|
||||
exit_page: last_event.pathname,
|
||||
is_bounce: state[:is_bounce],
|
||||
length: length,
|
||||
referrer: first_event.referrer,
|
||||
referrer_source: first_event.referrer_source,
|
||||
country_code: first_event.country_code,
|
||||
operating_system: first_event.operating_system,
|
||||
browser: first_event.browser,
|
||||
start: first_event.timestamp
|
||||
}) |> Repo.insert!
|
||||
end
|
||||
|
||||
{:stop, :normal, state}
|
||||
end
|
||||
|
||||
defp is_potential_leftover?(%{new_visitor: true}), do: false
|
||||
defp is_potential_leftover?(%{timestamp: timestamp}) do
|
||||
server_start_time = Application.get_env(:plausible, :server_start)
|
||||
Timex.diff(timestamp, server_start_time, :milliseconds) < @session_timeout
|
||||
end
|
||||
|
||||
end
|
||||
@ -1,81 +0,0 @@
|
||||
defmodule Plausible.Ingest.SessionTest do
|
||||
use Plausible.DataCase
|
||||
alias Plausible.Ingest
|
||||
|
||||
defp capture_session(user_id) do
|
||||
session_pid = :global.whereis_name(user_id)
|
||||
Process.monitor(session_pid)
|
||||
|
||||
assert_receive({:DOWN, session_pid, :process, _, :normal})
|
||||
|
||||
Repo.one(Plausible.Session)
|
||||
end
|
||||
|
||||
describe "on_event/1" do
|
||||
test "starts a new session if there is no session for user id" do
|
||||
pageview = insert(:pageview)
|
||||
|
||||
refute is_pid(:global.whereis_name(pageview.user_id))
|
||||
|
||||
Ingest.Session.on_event(pageview)
|
||||
|
||||
assert is_pid(:global.whereis_name(pageview.user_id))
|
||||
end
|
||||
|
||||
test "copies event data to session" do
|
||||
pageview = insert(:pageview)
|
||||
|
||||
Ingest.Session.on_event(pageview)
|
||||
|
||||
session = capture_session(pageview.user_id)
|
||||
|
||||
assert session.user_id == pageview.user_id
|
||||
assert session.new_visitor == pageview.new_visitor
|
||||
assert session.start == pageview.timestamp
|
||||
end
|
||||
|
||||
test "inserts bounced session when timeout fires after one pageview" do
|
||||
pageview = insert(:pageview)
|
||||
|
||||
Ingest.Session.on_event(pageview)
|
||||
|
||||
session = capture_session(pageview.user_id)
|
||||
assert session.is_bounce
|
||||
end
|
||||
|
||||
test "session with two events is not a bounce" do
|
||||
pageview = insert(:pageview)
|
||||
pageview2 = insert(:pageview, user_id: pageview.user_id)
|
||||
|
||||
Ingest.Session.on_event(pageview)
|
||||
Ingest.Session.on_event(pageview2)
|
||||
|
||||
session = capture_session(pageview.user_id)
|
||||
refute session.is_bounce
|
||||
end
|
||||
|
||||
test "captures the exit page" do
|
||||
pageview = insert(:pageview)
|
||||
pageview2 = insert(:pageview, user_id: pageview.user_id, pathname: "/exit")
|
||||
|
||||
Ingest.Session.on_event(pageview)
|
||||
Ingest.Session.on_event(pageview2)
|
||||
|
||||
session = capture_session(pageview.user_id)
|
||||
assert session.exit_page == "/exit"
|
||||
end
|
||||
end
|
||||
|
||||
describe "on_unload/1" do
|
||||
test "uses the unload timestamp to calculate session length" do
|
||||
pageview = insert(:pageview)
|
||||
unload_timestamp = Timex.shift(pageview.timestamp, seconds: 30)
|
||||
|
||||
Ingest.Session.on_event(pageview)
|
||||
Ingest.Session.on_unload(pageview.user_id, unload_timestamp)
|
||||
|
||||
session = capture_session(pageview.user_id)
|
||||
assert session.length == 30
|
||||
end
|
||||
end
|
||||
end
|
||||
Loading…
Reference in New Issue