Fix session duration for out-of-order events (#593)
parent
4d4f8ba5c3
commit
e786af648d
@ -0,0 +1,99 @@
|
||||
defmodule Plausible.Session.StoreTest do
|
||||
use Plausible.DataCase
|
||||
import Double
|
||||
alias Plausible.Session.{Store, WriteBuffer}
|
||||
|
||||
setup do
|
||||
buffer =
|
||||
WriteBuffer
|
||||
|> stub(:insert, fn _sessions -> nil end)
|
||||
|
||||
{:ok, store} = GenServer.start_link(Store, buffer: buffer)
|
||||
[store: store, buffer: buffer]
|
||||
end
|
||||
|
||||
test "creates a session from an event", %{store: store} do
|
||||
event =
|
||||
build(:event,
|
||||
name: "pageview",
|
||||
referrer: "ref",
|
||||
referrer_source: "refsource",
|
||||
utm_medium: "medium",
|
||||
utm_source: "source",
|
||||
utm_campaign: "campaign",
|
||||
browser: "browser",
|
||||
browser_version: "55",
|
||||
country_code: "EE",
|
||||
screen_size: "Desktop",
|
||||
operating_system: "Mac",
|
||||
operating_system_version: "11"
|
||||
)
|
||||
|
||||
Store.on_event(event, nil, store)
|
||||
|
||||
assert_receive({WriteBuffer, :insert, [sessions]})
|
||||
assert [session] = sessions
|
||||
assert session.hostname == event.hostname
|
||||
assert session.domain == event.domain
|
||||
assert session.user_id == event.user_id
|
||||
assert session.entry_page == event.pathname
|
||||
assert session.exit_page == event.pathname
|
||||
assert session.is_bounce == true
|
||||
assert session.duration == 0
|
||||
assert session.pageviews == 1
|
||||
assert session.events == 1
|
||||
assert session.referrer == event.referrer
|
||||
assert session.referrer_source == event.referrer_source
|
||||
assert session.utm_medium == event.utm_medium
|
||||
assert session.utm_source == event.utm_source
|
||||
assert session.utm_campaign == event.utm_campaign
|
||||
assert session.country_code == event.country_code
|
||||
assert session.screen_size == event.screen_size
|
||||
assert session.operating_system == event.operating_system
|
||||
assert session.operating_system_version == event.operating_system_version
|
||||
assert session.browser == event.browser
|
||||
assert session.browser_version == event.browser_version
|
||||
assert session.timestamp == event.timestamp
|
||||
assert session.start === event.timestamp
|
||||
end
|
||||
|
||||
test "updates a session", %{store: store} do
|
||||
timestamp = Timex.now()
|
||||
event1 = build(:event, name: "pageview", timestamp: timestamp |> Timex.shift(seconds: -10))
|
||||
|
||||
event2 =
|
||||
build(:event,
|
||||
domain: event1.domain,
|
||||
user_id: event1.user_id,
|
||||
name: "pageview",
|
||||
timestamp: timestamp
|
||||
)
|
||||
|
||||
Store.on_event(event1, nil, store)
|
||||
Store.on_event(event2, nil, store)
|
||||
assert_receive({WriteBuffer, :insert, [[session, _negative_record]]})
|
||||
assert session.is_bounce == false
|
||||
assert session.duration == 10
|
||||
assert session.pageviews == 2
|
||||
assert session.events == 2
|
||||
end
|
||||
|
||||
test "calculates duration correctly for out-of-order events", %{store: store} do
|
||||
timestamp = Timex.now()
|
||||
event1 = build(:event, name: "pageview", timestamp: timestamp |> Timex.shift(seconds: 10))
|
||||
|
||||
event2 =
|
||||
build(:event,
|
||||
domain: event1.domain,
|
||||
user_id: event1.user_id,
|
||||
name: "pageview",
|
||||
timestamp: timestamp
|
||||
)
|
||||
|
||||
Store.on_event(event1, nil, store)
|
||||
Store.on_event(event2, nil, store)
|
||||
|
||||
assert_receive({WriteBuffer, :insert, [[session, _negative_record]]})
|
||||
assert session.duration == 10
|
||||
end
|
||||
end
|
||||
Loading…
Reference in New Issue