Fix favicons (#2257)
parent
81a4e92b0a
commit
e849e03058
@ -0,0 +1,87 @@
|
||||
defmodule PlausibleWeb.FaviconTest do
|
||||
use Plausible.DataCase
|
||||
use Plug.Test
|
||||
alias PlausibleWeb.Favicon
|
||||
|
||||
import Mox
|
||||
setup :verify_on_exit!
|
||||
|
||||
setup_all do
|
||||
opts = PlausibleWeb.Favicon.init(nil)
|
||||
|
||||
%{plug_opts: opts}
|
||||
end
|
||||
|
||||
test "ignores request on a URL it does not need to handle", %{plug_opts: plug_opts} do
|
||||
old_conn = conn(:get, "/irrelevant")
|
||||
new_conn = Favicon.call(old_conn, plug_opts)
|
||||
|
||||
refute new_conn.halted
|
||||
assert old_conn == new_conn
|
||||
end
|
||||
|
||||
test "proxies request on favicon URL to duckduckgo", %{plug_opts: plug_opts} do
|
||||
expect(
|
||||
Plausible.HTTPClient.Mock,
|
||||
:get,
|
||||
fn "https://icons.duckduckgo.com/ip3/plausible.io.ico" ->
|
||||
{:ok, %Finch.Response{status: 200, body: "favicon response body"}}
|
||||
end
|
||||
)
|
||||
|
||||
conn =
|
||||
conn(:get, "/favicon/sources/plausible.io")
|
||||
|> Favicon.call(plug_opts)
|
||||
|
||||
assert conn.halted
|
||||
assert conn.status == 200
|
||||
assert conn.resp_body == "favicon response body"
|
||||
end
|
||||
|
||||
test "maps a categorized source to URL for favicon", %{plug_opts: plug_opts} do
|
||||
expect(
|
||||
Plausible.HTTPClient.Mock,
|
||||
:get,
|
||||
fn "https://icons.duckduckgo.com/ip3/facebook.com.ico" ->
|
||||
{:ok, %Finch.Response{status: 200, body: "favicon response body"}}
|
||||
end
|
||||
)
|
||||
|
||||
conn =
|
||||
conn(:get, "/favicon/sources/Facebook")
|
||||
|> Favicon.call(plug_opts)
|
||||
|
||||
assert conn.halted
|
||||
assert conn.status == 200
|
||||
assert conn.resp_body == "favicon response body"
|
||||
end
|
||||
|
||||
test "copies content-type header from the proxied response", %{plug_opts: plug_opts} do
|
||||
expect(
|
||||
Plausible.HTTPClient.Mock,
|
||||
:get,
|
||||
fn "https://icons.duckduckgo.com/ip3/plausible.io.ico" ->
|
||||
{:ok,
|
||||
%Finch.Response{
|
||||
status: 200,
|
||||
body: "favicon response body",
|
||||
headers: [
|
||||
{"transfer-encoding", "chunked"},
|
||||
{"content-type", "should-pass-through"}
|
||||
]
|
||||
}}
|
||||
end
|
||||
)
|
||||
|
||||
conn =
|
||||
conn(:get, "/favicon/sources/plausible.io")
|
||||
|> Favicon.call(plug_opts)
|
||||
|
||||
assert conn.halted
|
||||
assert conn.status == 200
|
||||
|
||||
assert conn.resp_headers == [
|
||||
{"content-type", "should-pass-through"}
|
||||
]
|
||||
end
|
||||
end
|
||||
@ -1,6 +1,7 @@
|
||||
{:ok, _} = Application.ensure_all_started(:ex_machina)
|
||||
Plausible.Test.ClickhouseSetup.run()
|
||||
Mimic.copy(FunWithFlags)
|
||||
Mox.defmock(Plausible.HTTPClient.Mock, for: Plausible.HTTPClient.Interface)
|
||||
ExUnit.start()
|
||||
Application.ensure_all_started(:double)
|
||||
Ecto.Adapters.SQL.Sandbox.mode(Plausible.Repo, :manual)
|
||||
|
||||
Loading…
Reference in New Issue