From ea504217c06fbce77ce0a1d018482c71f14051e8 Mon Sep 17 00:00:00 2001 From: Uku Taht Date: Thu, 30 Jul 2020 12:02:21 +0300 Subject: [PATCH] Escape single quote in CH query (#258) --- lib/plausible/clickhouse.ex | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/plausible/clickhouse.ex b/lib/plausible/clickhouse.ex index bdcddd678..6a5ed38cf 100644 --- a/lib/plausible/clickhouse.ex +++ b/lib/plausible/clickhouse.ex @@ -1,6 +1,7 @@ defmodule Plausible.Clickhouse do def all(query) do {q, params} = Ecto.Adapters.SQL.to_sql(:all, Plausible.Repo, query) + params = Enum.map(params, &escape_quote/1) q = String.replace(q, ~r/\$[0-9]+/, "?") res = Clickhousex.query!(:clickhouse, q, params, log: {Plausible.Clickhouse, :log, []}) @@ -91,8 +92,9 @@ defmodule Plausible.Clickhouse do Clickhousex.query(:clickhouse, insert, args, log: {Plausible.Clickhouse, :log, []}) end - def escape_quote(nil), do: nil - def escape_quote(s), do: String.replace(s, "'", "''") + def escape_quote(l) when is_list(l), do: Enum.map(l, &escape_quote/1) + def escape_quote(s) when is_binary(s), do: String.replace(s, "'", "''") + def escape_quote(thing), do: thing def log(query) do require Logger