From eed662fa40d192a5b4271600e5d4e6ab9b4550a5 Mon Sep 17 00:00:00 2001 From: Karl-Aksel Puulmann Date: Tue, 2 Apr 2024 17:15:03 +0300 Subject: [PATCH] events, pageviews are strictly event metrics --- lib/plausible/stats/table_decider.ex | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/plausible/stats/table_decider.ex b/lib/plausible/stats/table_decider.ex index 2ce4a3d5f..d14bc593f 100644 --- a/lib/plausible/stats/table_decider.ex +++ b/lib/plausible/stats/table_decider.ex @@ -42,19 +42,17 @@ defmodule Plausible.Stats.TableDecider do defp metric_partitioner(_, :conversion_rate), do: :event defp metric_partitioner(_, :average_revenue), do: :event defp metric_partitioner(_, :total_revenue), do: :event + defp metric_partitioner(_, :pageviews), do: :event + defp metric_partitioner(_, :events), do: :event defp metric_partitioner(_, :bounce_rate), do: :session defp metric_partitioner(_, :visit_duration), do: :session defp metric_partitioner(_, :views_per_visit), do: :session # Metrics which used to only be queried from one table but can be calculated from either defp metric_partitioner(%Query{experimental_reduced_joins?: true}, :visits), do: :either - defp metric_partitioner(%Query{experimental_reduced_joins?: true}, :pageviews), do: :either - defp metric_partitioner(%Query{experimental_reduced_joins?: true}, :events), do: :either defp metric_partitioner(%Query{experimental_reduced_joins?: true}, :visitors), do: :either defp metric_partitioner(_, :visits), do: :session - defp metric_partitioner(_, :pageviews), do: :event - defp metric_partitioner(_, :events), do: :event defp metric_partitioner(_, :visitors), do: :event # Calculated metrics - handled on callsite separately from other metrics. defp metric_partitioner(_, :time_on_page), do: :other