From ef0efa2d630abda8097bd4e28a4bf821b435357b Mon Sep 17 00:00:00 2001 From: Uku Taht Date: Wed, 31 Mar 2021 16:08:30 +0300 Subject: [PATCH] Clean up pinned-header-hoc Fixes #639 --- assets/js/dashboard/pinned-header-hoc.js | 7 ++++--- assets/js/dashboard/realtime.js | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/assets/js/dashboard/pinned-header-hoc.js b/assets/js/dashboard/pinned-header-hoc.js index 51547a252..3150749db 100644 --- a/assets/js/dashboard/pinned-header-hoc.js +++ b/assets/js/dashboard/pinned-header-hoc.js @@ -1,6 +1,6 @@ import React from 'react'; -export const withPinnedHeader = (WrappedComponent, flagName) => { +export const withPinnedHeader = (WrappedComponent, selector) => { return class extends React.Component { constructor(props) { super(props) @@ -19,11 +19,12 @@ export const withPinnedHeader = (WrappedComponent, flagName) => { threshold: [0, 1] }); - this.observer.observe(document.querySelector("#stats-container-top")); + this.el = document.querySelector(selector) + this.observer.observe(this.el); } componentWillUnmount() { - this.observer.unobserve(document.querySelector("#stats-container-top")); + this.observer.unobserve(this.el); } render() { diff --git a/assets/js/dashboard/realtime.js b/assets/js/dashboard/realtime.js index e17df67ae..1a05c8d66 100644 --- a/assets/js/dashboard/realtime.js +++ b/assets/js/dashboard/realtime.js @@ -54,4 +54,4 @@ class Realtime extends React.Component { } } -export default withPinnedHeader(Realtime); +export default withPinnedHeader(Realtime, '#stats-container-top');