Handle unexpected Google Analytics responses (#2158)

This commit handles unexpected Google Analytics responses while
importing, and logs to Sentry and Logger. This will improve
observability when things go wrong with GA imports.
pull/2162/head
Vinicius Brasil 4 years ago committed by GitHub
parent e8d197f434
commit f4a242ac71
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -1,4 +1,5 @@
defmodule Plausible.Google.HTTP do
require Logger
alias Plausible.HTTPClient
@spec get_report(module(), Plausible.Google.ReportRequest.t()) ::
@ -36,13 +37,33 @@ defmodule Plausible.Google.HTTP do
|> http_client.request(Plausible.Finch)
with {:ok, %{status: 200, body: body}} <- response,
{:ok, %{"reports" => [report | _]}} <- Jason.decode(body),
{:ok, report} <- parse_report_from_response(body),
token <- Map.get(report, "nextPageToken"),
report <- convert_to_maps(report) do
{:ok, report} <- convert_to_maps(report) do
{:ok, {report, token}}
end
end
defp parse_report_from_response(raw_body) do
with {:ok, map} <- Jason.decode(raw_body),
%{"reports" => [report | _]} <- map do
{:ok, report}
else
{:error, cause} ->
Logger.error("Google Analytics: Failed to parse JSON. Reason: #{inspect(cause)}")
Sentry.Context.set_extra_context(%{google_analytics_response: raw_body})
{:error, cause}
%{} = response ->
Logger.error(
"Google Analytics: Failed to find report in response. Reason: #{inspect(response)}"
)
Sentry.Context.set_extra_context(%{google_analytics_response: response})
{:error, {:invalid_response, response}}
end
end
defp convert_to_maps(%{
"data" => %{} = data,
"columnHeader" => %{
@ -53,11 +74,23 @@ defmodule Plausible.Google.HTTP do
metric_headers = Enum.map(metric_headers, & &1["name"])
rows = Map.get(data, "rows", [])
Enum.map(rows, fn %{"dimensions" => dimensions, "metrics" => [%{"values" => metrics}]} ->
metrics = Enum.zip(metric_headers, metrics)
dimensions = Enum.zip(dimension_headers, dimensions)
%{metrics: Map.new(metrics), dimensions: Map.new(dimensions)}
end)
report =
Enum.map(rows, fn %{"dimensions" => dimensions, "metrics" => [%{"values" => metrics}]} ->
metrics = Enum.zip(metric_headers, metrics)
dimensions = Enum.zip(dimension_headers, dimensions)
%{metrics: Map.new(metrics), dimensions: Map.new(dimensions)}
end)
{:ok, report}
end
defp convert_to_maps(response) do
Logger.error(
"Google Analytics: Failed to read report in response. Reason: #{inspect(response)}"
)
Sentry.Context.set_extra_context(%{google_analytics_response: response})
{:error, {:invalid_response, response}}
end
def list_sites(access_token) do

Loading…
Cancel
Save