From f71f98a52106f228744c7f79c2c76d22397d81bf Mon Sep 17 00:00:00 2001 From: Uku Taht Date: Wed, 20 Nov 2019 16:42:45 +0800 Subject: [PATCH] Test Google referrer drilldown --- config/config.exs | 3 ++- config/test.exs | 3 ++- .../controllers/api/stats_controller.ex | 5 ++++- .../api/stats_controller/referrers_test.exs | 14 ++++++++++++++ test/support/google_api_mock.ex | 8 ++++++++ 5 files changed, 30 insertions(+), 3 deletions(-) create mode 100644 test/support/google_api_mock.ex diff --git a/config/config.exs b/config/config.exs index 8e2254dca..88d96281f 100644 --- a/config/config.exs +++ b/config/config.exs @@ -42,7 +42,8 @@ config :ref_inspector, database_path: "priv/ref_inspector" config :plausible, - paddle_api: Plausible.Billing.PaddleApi + paddle_api: Plausible.Billing.PaddleApi, + google_api: Plausible.Google.Api # Import environment specific config. This must remain at the bottom # of this file so it overrides the configuration defined above. diff --git a/config/test.exs b/config/test.exs index 979fbe82e..1bbd3e5ca 100644 --- a/config/test.exs +++ b/config/test.exs @@ -24,4 +24,5 @@ config :plausible, Plausible.Mailer, adapter: Bamboo.TestAdapter config :plausible, - paddle_api: Plausible.PaddleApi.Mock + paddle_api: Plausible.PaddleApi.Mock, + google_api: Plausible.Google.Api.Mock diff --git a/lib/plausible_web/controllers/api/stats_controller.ex b/lib/plausible_web/controllers/api/stats_controller.ex index af48b7d75..95312470e 100644 --- a/lib/plausible_web/controllers/api/stats_controller.ex +++ b/lib/plausible_web/controllers/api/stats_controller.ex @@ -32,12 +32,15 @@ defmodule PlausibleWeb.Api.StatsController do json(conn, Stats.top_referrers(site, query, params["limit"] || 5)) end + + @google_api Application.fetch_env!(:plausible, :google_api) + def referrer_drilldown(conn, %{"referrer" => "Google"} = params) do site = conn.assigns[:site] |> Repo.preload(:google_auth) query = Stats.Query.from(site.timezone, params) search_terms = if site.google_auth && site.google_auth.property && !query.filters["goal"] do - Plausible.Google.Api.fetch_stats(site.google_auth, query) + @google_api.fetch_stats(site.google_auth, query) end case search_terms do diff --git a/test/plausible_web/controllers/api/stats_controller/referrers_test.exs b/test/plausible_web/controllers/api/stats_controller/referrers_test.exs index 961bf4fe6..38b657d93 100644 --- a/test/plausible_web/controllers/api/stats_controller/referrers_test.exs +++ b/test/plausible_web/controllers/api/stats_controller/referrers_test.exs @@ -84,5 +84,19 @@ defmodule PlausibleWeb.Api.StatsController.ReferrersTest do ] } end + + test "gets keywords from Google", %{conn: conn, user: user, site: site} do + insert(:google_auth, user: user, user: user,site: site, property: "sc-domain:example.com") + insert(:pageview, hostname: site.domain, referrer: "google.com", referrer_source: "Google", timestamp: ~N[2019-01-01 01:00:00]) + insert(:pageview, hostname: site.domain, referrer: "google.com", referrer_source: "Google", timestamp: ~N[2019-01-01 02:00:00]) + + conn = get(conn, "/api/stats/#{site.domain}/referrers/Google?period=day&date=2019-01-01") + {:ok, terms} = Plausible.Google.Api.Mock.fetch_stats(nil, nil) + + assert json_response(conn, 200) == %{ + "total_visitors" => 2, + "search_terms" => terms + } + end end end diff --git a/test/support/google_api_mock.ex b/test/support/google_api_mock.ex new file mode 100644 index 000000000..5060242a1 --- /dev/null +++ b/test/support/google_api_mock.ex @@ -0,0 +1,8 @@ +defmodule Plausible.Google.Api.Mock do + def fetch_stats(_auth, _query) do + {:ok, [ + %{"name" => "simple web analytics", "count" => 6}, + %{"name" => "open-source analytics", "count" => 2}, + ]} + end +end