From ffb4133cd6e229dbb4cdbcad9c321f9d33de99f0 Mon Sep 17 00:00:00 2001 From: Karl-Aksel Puulmann Date: Tue, 2 Apr 2024 14:20:52 +0300 Subject: [PATCH] Add some TODOs --- lib/plausible/stats/base.ex | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/plausible/stats/base.ex b/lib/plausible/stats/base.ex index 5f469fa68..16cac8853 100644 --- a/lib/plausible/stats/base.ex +++ b/lib/plausible/stats/base.ex @@ -119,6 +119,7 @@ defmodule Plausible.Stats.Base do &filter_by_custom_prop/2 ) + # :TODO: Maybe check if joined if query.experimental_reduced_joins? do q = filter_by_visit_props(q, query) end @@ -158,6 +159,7 @@ defmodule Plausible.Stats.Base do "city" => "city_geoname_id" } + # :TODO: handle entry/exit page conditionally defp filter_by_visit_props(q, query) do Enum.reduce(Filters.visit_props(), q, fn prop_name, sessions_q -> filter_key = "visit:" <> prop_name