You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
analytics/lib/plausible
RobertJoonas 672d682e95
Bring Stats API up to speed: Add `conversion_rate` to Aggregate and Breakdown (#3739)
* disable event metric with include_imported in every case

* add missing test for metric validation

* refactor metric validation functions

* implement conversion_rate metric validation

* move calculate_cr function into Stats.Util

* Refactor: Move aggregate CR logic into Stats.aggregate

* define atoms to exist

* Ensure that CR does not depend on visitors being queried

If 'visitors' are already queried, we'll use that value. Otherwise we'll
need to make another query to fetch it.

* confirm Stats API aggregate supports CR (tests only)

* small refactor

This is the only 'event_property' left after pattern matching on all
others in the function clauses defined above.

* Make it possible to optionally query conversion_rate

...in breakdown queries (excluding goal and custom prop breakdown)

* A little refactor asking for revenue metrics

1. The `@revenue_metrics` module attribute is an empty list on full build
   anyway
2. We don't need to query for revenue metrics if there are no revenue goals
   returned in the given query (even if revenue goals exist in site.goals)
3. Revenue metrics are already dropped in prop breakdown without a goal
   filter via (get_revenue_tracking_currency/3)

* Make it possible to optionally query conversion_rate (continuation)

... also from a custom prop and goal breakdown

* Frontend adjustments to the Locations report

* Display conversion rate in Regions and Cities (ListReport view)
* Display total conversions, conversions (visitors), and CR in the
  "Details" modals of Countries, Regions, and Cities
* Move the percentage into a separate column in the Countries details table

* confirm Stats API breakdown supports conversion_rate (tests only)

* small refactor: extract maybe_add_time_on_page function

* Make it possible to query cr alone

... (without the visitors metric). Already supported in aggregate, this
commit only implements it for the breakdown API.

* Reuse Stats.Util helper functions from b02db88 for aggregate API

We can follow the same logic as with breakdown for manually adding
`visitors` into the metrics list and taking it out of the response
later on.

That way we don't have to make another query, e.g. in a case where
only pageviews and conversion rate is queried. Also keeps things
consistent.

* changelog update

* fix test after resolving merge conflict

* Use explicit string->atom mapping instead of casting

* alias Util module instead of importing it

* use Enum.empty instead of Enum.any

* improve readability

* rename special_metrics to computed_metrics and explain with a comment

* rename visitors_without_event_filters to total_visitors

* keep a single function for removing unwanted metrics

---------

Co-authored-by: Adrian Gruntkowski <adrian.gruntkowski@gmail.com>
3 years ago
..
auth Bugfix: available features for expired trials, no subscriptions (#3740) 3 years ago
billing Bugfix: available features for expired trials, no subscriptions (#3740) 3 years ago
cache Generalize Cache/Warmers - extract only specifics to `Site.Cache` (#3716) 3 years ago
data_migration Update credo config + extras (#3547) 3 years ago
event Flush Clickhouse buffers faster by encoding early (#3623) 3 years ago
funnel Add small build option (#3536) 3 years ago
goal Small build updates (#3546) 3 years ago
google Extract Universal Analytics import logic (#3700) 3 years ago
helpers Small build updates (#3546) 3 years ago
imported Add multiple imports per site (#3724) 3 years ago
ingestion IP Block List (#3761) 3 years ago
open_telemetry Make OpenTelemetry sampler ratio configurable via env (#3514) 3 years ago
plugins/api Plugins API exentsions (custom props, bulk goal delete, goal creation => ListResponse always) (#3593) 3 years ago
sentry Upgrade Erlang/Elixir stack (#3454) 3 years ago
session Flush Clickhouse buffers faster by encoding early (#3623) 3 years ago
shield IP Block List (#3761) 3 years ago
site Add multiple imports per site (#3724) 3 years ago
stats Bring Stats API up to speed: Add `conversion_rate` to Aggregate and Breakdown (#3739) 3 years ago
telemetry Gatekeep ingestion pipeline (#2472) 4 years ago
application.ex IP Block List (#3761) 3 years ago
async_insert_repo.ex Switch to new clickhouse adapter (ch/chto) (#2733) 4 years ago
cache.ex IP Block List (#3761) 3 years ago
cldr.ex Revenue tracking: Add currency field to goal creation (#2948) 4 years ago
clickhouse_event_v2.ex Protect against custom props payloads breaking event insertions (#3617) 3 years ago
clickhouse_repo.ex Switch to new clickhouse adapter (ch/chto) (#2733) 4 years ago
clickhouse_session_v2.ex use ecto_ch (#2890) 4 years ago
data_migration.ex Make self-hosted data migration easier (#2865) 4 years ago
debug_replay_info.ex Add debug_replay_info context to Sentry Stats reports (#3189) 3 years ago
geo.ex Upgrade Erlang/Elixir stack (#3454) 3 years ago
goals.ex Small build updates (#3546) 3 years ago
http_client.ex Use Phoenix LiveView for the upgrade page (#3382) 3 years ago
import_deletion_repo.ex Split clickhouse repos - making the main one read only (#2826) 4 years ago
imported.ex Add multiple imports per site (#3724) 3 years ago
ingest_repo.ex Switch to new clickhouse adapter (ch/chto) (#2733) 4 years ago
mailer.ex Fix and refactor invitation logic (#3376) 3 years ago
migration_utils.ex Add migration for minmax indexes on session timestamps (#3772) 3 years ago
open_telemetry.ex Implement trace ID ratio-based sampling for OpenTelemetry (#3499) 3 years ago
pagination.ex Implement new sites view (#3463) 3 years ago
prom_ex.ex Implement new sites view (#3463) 3 years ago
props.ex Limit Custom Properties access in Stats API (#3670) 3 years ago
purge.ex Add multiple imports per site (#3724) 3 years ago
rate_limit.ex rm Hammer (#3571) 3 years ago
repo.ex Implement new sites view (#3463) 3 years ago
shields.ex IP Block List (#3761) 3 years ago
site.ex Add multiple imports per site (#3724) 3 years ago
sites.ex Add multiple imports per site (#3724) 3 years ago
stats.ex Add small build option (#3536) 3 years ago
themes.ex Adds dark mode to entire dashboard (#467) 6 years ago
timezones.ex Add multiple imports per site (#3724) 3 years ago
users.ex Bugfix: available features for expired trials, no subscriptions (#3740) 3 years ago