Commit Graph

40 Commits (094dbdaf2be7ef0e16afc256fba014a651bbf0fc)

Author SHA1 Message Date
Peter Steinberger fec48a5006 refactor(exec): split host flows and harden safe-bin trust 9 months ago
Peter Steinberger 3267f09264 refactor(node-host): extract invoke result helpers 9 months ago
Peter Steinberger 9386075b7b perf(test): fold node-host runner tests into sanitize env suite 9 months ago
Peter Steinberger a0e763168f refactor(exec-approvals): share socket default merge 9 months ago
Peter Steinberger 18342b0a5b refactor(node-host): dedupe exec finished event emission 9 months ago
Bin Deng c0cd3c3c08
fix: add safety timeout to session.compact() to prevent lane deadlock (#16533)
Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 21e4045addca7a424828478d84dd5e4b202cbcfd
Co-authored-by: BinHPdev <219093083+BinHPdev@users.noreply.github.com>
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Reviewed-by: @gumadeiras
9 months ago
Peter Steinberger 013e8f6b3b fix: harden exec PATH handling 9 months ago
Peter Steinberger cb3290fca3 fix(node-host): enforce system.run rawCommand/argv consistency 9 months ago
Peter Steinberger 1d46d3ae4e refactor(node-host): extract invoke handlers 9 months ago
Onur 424d2dddf5
fix: prevent act:evaluate hangs from getting browser tool stuck/killed (#13498)
* fix(browser): prevent permanent timeout after stuck evaluate

Thread AbortSignal from client-fetch through dispatcher to Playwright
operations. When a timeout fires, force-disconnect the Playwright CDP
connection to unblock the serialized command queue, allowing the next
call to reconnect transparently.

Key changes:
- client-fetch.ts: proper AbortController with signal propagation
- pw-session.ts: new forceDisconnectPlaywrightForTarget()
- pw-tools-core.interactions.ts: accept signal, align inner timeout
  to outer-500ms, inject in-browser Promise.race for async evaluates
- routes/dispatcher.ts + types.ts: propagate signal through dispatch
- server.ts + bridge-server.ts: Express middleware creates AbortSignal
  from request lifecycle
- client-actions-core.ts: add timeoutMs to evaluate type

Fixes #10994

* fix(browser): v2 - force-disconnect via Connection.close() instead of browser.close()

When page.evaluate() is stuck on a hung CDP transport, browser.close() also
hangs because it tries to send a close command through the same stuck pipe.

v2 fix: forceDisconnectPlaywrightForTarget now directly calls Playwright's
internal Connection.close() which locally rejects all pending callbacks and
emits 'disconnected' without touching the network. This instantly unblocks
all stuck Playwright operations.

closePlaywrightBrowserConnection (clean shutdown) now also has a 3s timeout
fallback that drops to forceDropConnection if browser.close() hangs.

Fixes permanent browser timeout after stuck evaluate.

* fix(browser): v3 - fire-and-forget browser.close() instead of Connection.close()

v2's forceDropConnection called browser._connection.close() which corrupts
the entire Playwright instance because Connection is shared across all
objects (BrowserType, Browser, Page, etc.). This prevented reconnection
with cascading 'connectOverCDP: Force-disconnected' errors.

v3 fix: forceDisconnectPlaywrightForTarget now:
1. Nulls cached connection immediately
2. Fire-and-forgets browser.close() (doesn't await — it may hang)
3. Next connectBrowser() creates a fresh connectOverCDP WebSocket

Each connectOverCDP creates an independent WebSocket to the CDP endpoint,
so the new connection is unaffected by the old one's pending close.
The old browser.close() eventually resolves when the in-browser evaluate
timeout fires, or the old connection gets GC'd.

* fix(browser): v4 - clear connecting state and remove stale disconnect listeners

The reconnect was failing because:
1. forceDisconnectPlaywrightForTarget nulled cached but not connecting,
   so subsequent calls could await a stale promise
2. The old browser's 'disconnected' event handler raced with new
   connections, nulling the fresh cached reference

Fix: null both cached and connecting, and removeAllListeners on the
old browser before fire-and-forget close.

* fix(browser): v5 - use raw CDP Runtime.terminateExecution to kill stuck evaluate

When forceDisconnectPlaywrightForTarget fires, open a raw WebSocket
to the stuck page's CDP endpoint and send Runtime.terminateExecution.
This kills running JS without navigating away or crashing the page.
Also clear connecting state and remove stale disconnect listeners.

* fix(browser): abort cancels stuck evaluate

* Browser: always cleanup evaluate abort listener

* Chore: remove Playwright debug scripts

* Docs: add CDP evaluate refactor plan

* Browser: refactor Playwright force-disconnect

* Browser: abort stops evaluate promptly

* Node host: extract withTimeout helper

* Browser: remove disconnected listener safely

* Changelog: note act:evaluate hang fix

---------

Co-authored-by: Bob <bob@dutifulbob.com>
9 months ago
Peter Steinberger a7f4a53ce8 fix: harden Windows exec allowlist 10 months ago
cpojer f06dd8df06
chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 10 months ago
cpojer e5eb9610dc
chore: Fix TypeScript errors 1/n. 10 months ago
cpojer 5ceff756e1
chore: Enable "curly" rule to avoid single-statement if confusion/errors. 10 months ago
cpojer 15792b153f
chore: Enable more lint rules, disable some that trigger a lot. Will clean up later. 10 months ago
Peter Steinberger 9a7160786a refactor: rename to openclaw 10 months ago
Peter Steinberger 6d16a658e5 refactor: rename clawdbot to moltbot with legacy compat 10 months ago
Peter Steinberger e7fdccce39 refactor: route browser control via gateway/node 10 months ago
Peter Steinberger 5662a9cdfc fix: honor tools.exec ask/security in approvals 10 months ago
Peter Steinberger c3cb26f7ca feat: add node browser proxy routing 10 months ago
Peter Steinberger e872f5335b fix: allow chained exec allowlists
Co-authored-by: Lucas Czekaj <1464539+czekaj@users.noreply.github.com>
10 months ago
Lucas Czekaj 4b3e9c0f33 fix(exec): align node exec approvals (#1425)
Thanks @czekaj.

Co-authored-by: Lucas Czekaj <lukasz@czekaj.us>
10 months ago
Peter Steinberger 7e1a17e5e6 fix: unify exec approval ids 10 months ago
Peter Steinberger 28e547f120 fix: stabilize ci 10 months ago
Peter Steinberger 3b18efdd25 feat: tighten exec allowlist gating 10 months ago
Peter Steinberger 9bd6b3fd54 feat: show node PATH and bootstrap node host env 10 months ago
Peter Steinberger 1ad4a7194e fix: allow node exec fallback and defer node approvals 10 months ago
Peter Steinberger 15e3a2a395 fix: sanitize node invoke result params 10 months ago
Peter Steinberger 28c49db494 fix: default exec security to allowlist 10 months ago
Peter Steinberger 87343c374e feat: route exec approvals via gateway 10 months ago
Peter Steinberger 588dc43787 fix: resolve format/build failures 10 months ago
Peter Steinberger 3776de906f fix: stabilize gateway ws + iOS 10 months ago
Peter Steinberger 2f8206862a refactor: remove bridge protocol 10 months ago
Peter Steinberger ab340c82fb fix: stabilize tests and logging 10 months ago
Peter Steinberger 081123c0e4 feat: route macOS node exec via app IPC 10 months ago
Peter Steinberger 1721d04405 feat: add node core/ui versions in bridge 10 months ago
Peter Steinberger 3686bde783 feat: add exec approvals tooling and service status 10 months ago
Peter Steinberger 65bed815a8 fix: resolve ci failures 10 months ago
Peter Steinberger f76ab69612 feat: add memory indexing progress options 10 months ago
Peter Steinberger ae0b4c4990 feat: add exec host routing + node daemon 10 months ago