You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gpt-pilot/extensions
Vincent Koc 89a1e99815
fix(slack): finalize replyToMode off threading behavior (#23799)
* fix: make replyToMode 'off' actually prevent threading in Slack

Three independent bugs caused Slack replies to always create threads
even when replyToMode was set to 'off':

1. Typing indicator created threads via statusThreadTs fallback (#16868)
   - resolveSlackThreadTargets fell back to messageTs for statusThreadTs
   - 'is typing...' was posted as thread reply, creating a thread
   - Fix: remove messageTs fallback, let statusThreadTs be undefined

2. [[reply_to_current]] tags bypassed replyToMode entirely (#16080)
   - Slack dock had allowExplicitReplyTagsWhenOff: true
   - Reply tags from system prompt always threaded regardless of config
   - Fix: set allowExplicitReplyTagsWhenOff to false for Slack

3. Contradictory replyToMode defaults in codebase (#20827)
   - monitor/provider.ts defaulted to 'all'
   - accounts.ts defaulted to 'off' (matching docs)
   - Fix: align provider.ts default to 'off' per documentation

Fixes: openclaw/openclaw#16868, openclaw/openclaw#16080, openclaw/openclaw#20827

* fix(slack): respect replyToMode in DMs even with typing indicator thread

When replyToMode is 'off' in DMs, replies should stay in the main
conversation even when the typing indicator creates a thread context.

Previously, when incomingThreadTs was set (from the typing indicator's
thread), replyToMode was forced to 'all', causing all replies to go
into the thread.

Now, for direct messages, the user's configured replyToMode is always
respected. For channels/groups, the existing behavior is preserved
(stay in thread if already in one).

This fix:
- Keeps the typing indicator working (statusThreadTs fallback preserved)
- Prevents DM replies from being forced into threads
- Maintains channel thread continuity

Fixes #16868

* refactor(slack): eliminate redundant resolveSlackThreadContext call

- Add isThreadReply to resolveSlackThreadTargets return value
- Remove duplicate call in dispatch.ts
- Addresses greptile review feedback with cleaner DRY approach

* docs(slack): add JSDoc to resolveSlackThreadTargets

Document return values including isThreadReply distinction between
genuine user thread replies vs bot status message thread context.

* docs(changelog): record Slack replyToMode off threading fixes

---------

Co-authored-by: James <jamesrp13@gmail.com>
Co-authored-by: theoseo <suhong.seo@gmail.com>
9 months ago
..
bluebubbles fix(bluebubbles): tighten chat target handling 9 months ago
copilot-proxy fix(ci): sync plugin versions and harden install smoke 9 months ago
device-pair Security: disable plugin runtime command execution primitive (#20828) 9 months ago
diagnostics-otel fix(ci): sync plugin versions and harden install smoke 9 months ago
discord refactor(channels): reuse runtime group policy helpers 9 months ago
feishu fix(feishu): prefer video file_key for inbound media 9 months ago
google-antigravity-auth fix(ci): sync plugin versions and harden install smoke 9 months ago
google-gemini-cli-auth fix(ci): sync plugin versions and harden install smoke 9 months ago
googlechat refactor(channels): reuse runtime group policy helpers 9 months ago
imessage refactor(channels): reuse runtime group policy helpers 9 months ago
irc refactor(channels): reuse runtime group policy helpers 9 months ago
line refactor(channels): reuse runtime group policy helpers 9 months ago
llm-task fix(ci): sync plugin versions and harden install smoke 9 months ago
lobster fix(ci): sync plugin versions and harden install smoke 9 months ago
matrix refactor(channels): reuse runtime group policy helpers 9 months ago
mattermost refactor(channels): reuse runtime group policy helpers 9 months ago
memory-core fix(ci): sync plugin versions and harden install smoke 9 months ago
memory-lancedb fix(ci): sync plugin versions and harden install smoke 9 months ago
minimax-portal-auth fix(ci): sync plugin versions and harden install smoke 9 months ago
msteams refactor(channels): reuse runtime group policy helpers 9 months ago
nextcloud-talk refactor(channels): reuse runtime group policy helpers 9 months ago
nostr fix(ci): sync plugin versions and harden install smoke 9 months ago
open-prose fix(ci): sync plugin versions and harden install smoke 9 months ago
phone-control style: align formatting with oxfmt 0.33 9 months ago
qwen-portal-auth TypeScript: add extensions to tsconfig and fix type errors (#12781) 10 months ago
shared refactor(extensions): dedupe connector helper usage 9 months ago
signal refactor(channels): reuse runtime group policy helpers 9 months ago
slack fix(slack): finalize replyToMode off threading behavior (#23799) 9 months ago
synology-chat test: speed up slow media and synology suites 9 months ago
talk-voice Gateway/Plugins: device pairing + phone control plugins (#11755) 10 months ago
telegram fix(telegram): wire webhookPort through config and startup 9 months ago
thread-ownership test(extensions): cast fetch mocks to satisfy tsgo 9 months ago
tlon refactor(plugin-sdk): unify channel dedupe primitives 9 months ago
twitch refactor(security): unify secure id paths and guard weak patterns 9 months ago
voice-call fix(voice-call): tighten manager outbound behavior 9 months ago
whatsapp refactor(channels): reuse runtime group policy helpers 9 months ago
zalo test(zalo): broaden webhook monitor coverage 9 months ago
zalouser refactor(channels): reuse runtime group policy helpers 9 months ago