You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
80 lines
2.6 KiB
Python
80 lines
2.6 KiB
Python
|
2 months ago
|
"""Database sessions bind to immutable user IDs, not reusable usernames."""
|
||
|
|
|
||
|
|
from __future__ import annotations
|
||
|
|
|
||
|
|
import json
|
||
|
|
import time
|
||
|
|
|
||
|
|
import pytest
|
||
|
|
|
||
|
|
from virsh_panel.auth import DatabaseSessionStore, SessionStore
|
||
|
|
|
||
|
|
|
||
|
|
class _Records:
|
||
|
|
def __init__(self):
|
||
|
|
self.values = {}
|
||
|
|
|
||
|
|
def get(self, record_type, record_key):
|
||
|
|
return self.values.get((record_type, record_key))
|
||
|
|
|
||
|
|
def set(self, record_type, record_key, value):
|
||
|
|
self.values[(record_type, record_key)] = value
|
||
|
|
|
||
|
|
def delete(self, record_type, record_key):
|
||
|
|
self.values.pop((record_type, record_key), None)
|
||
|
|
|
||
|
|
|
||
|
|
def test_database_session_round_trips_immutable_user_id():
|
||
|
|
records = _Records()
|
||
|
|
sessions = DatabaseSessionStore(records)
|
||
|
|
created = sessions.issue("operator", user_id=47)
|
||
|
|
assert created.user_id == 47
|
||
|
|
key = sessions._key(created.token)
|
||
|
|
payload = json.loads(records.get("session", key))
|
||
|
|
assert payload["user_id"] == 47
|
||
|
|
assert created.token not in records.get("session", key)
|
||
|
|
restored = DatabaseSessionStore(records).get(created.token)
|
||
|
|
assert restored == created
|
||
|
|
|
||
|
|
|
||
|
|
@pytest.mark.parametrize("invalid_id", [None, 0, -1, True, "47", 47.0])
|
||
|
|
def test_database_session_issue_refuses_missing_or_invalid_user_id(invalid_id):
|
||
|
|
sessions = DatabaseSessionStore(_Records())
|
||
|
|
with pytest.raises(ValueError, match="positive user ID"):
|
||
|
|
sessions.issue("operator", user_id=invalid_id)
|
||
|
|
|
||
|
|
|
||
|
|
@pytest.mark.parametrize("invalid_id", [None, 0, -1, True, "47", 47.0])
|
||
|
|
def test_database_session_get_rejects_legacy_or_invalid_id(invalid_id):
|
||
|
|
records = _Records()
|
||
|
|
sessions = DatabaseSessionStore(records)
|
||
|
|
token = "legacy-token"
|
||
|
|
payload = {
|
||
|
|
"username": "operator", "csrf_token": "csrf-token",
|
||
|
|
"expires_at": time.time() + 100,
|
||
|
|
}
|
||
|
|
if invalid_id is not None:
|
||
|
|
payload["user_id"] = invalid_id
|
||
|
|
records.set("session", sessions._key(token), json.dumps(payload))
|
||
|
|
assert sessions.get(token) is None
|
||
|
|
|
||
|
|
|
||
|
|
def test_database_session_expired_token_is_removed():
|
||
|
|
records = _Records()
|
||
|
|
sessions = DatabaseSessionStore(records)
|
||
|
|
token = "expired-token"
|
||
|
|
key = sessions._key(token)
|
||
|
|
records.set("session", key, json.dumps({
|
||
|
|
"username": "operator", "user_id": 47,
|
||
|
|
"csrf_token": "csrf-token", "expires_at": time.time() - 1,
|
||
|
|
}))
|
||
|
|
assert sessions.get(token) is None
|
||
|
|
assert records.get("session", key) is None
|
||
|
|
|
||
|
|
|
||
|
|
def test_injected_memory_sessions_keep_username_only_compatibility():
|
||
|
|
sessions = SessionStore()
|
||
|
|
created = sessions.issue("test-admin")
|
||
|
|
assert created.user_id is None
|
||
|
|
assert sessions.get(created.token) == created
|